Merge pull request #34 from drone/FFM-1213_delete_events

(FFM-1213) Can handle SSE delete events not to clear the cache

Author: Andrew-Hayes

dto/key.go

@@ -11,4 +11,10 @@ const (
 	KeyFeature = "flag"
 	// KeySegment identifies segment messages from ff server or stream
 	KeySegment = "target-segment"
+	// SsePatchEvent identifies a patch event from the SSE stream
+	SsePatchEvent = "patch"
+	// SseDeleteEvent identifies a delete event from the SSE stream
+	SseDeleteEvent = "delete"
+	// SseCreateEvent identifies a create event from the SSE stream
+	SseCreateEvent = "create"
 )

stream/sse.go

@@ -63,22 +63,34 @@ func (c *SSEClient) Connect(environment string) error {
 				case dto.KeyFeature:
 					// maybe is better to send event on memory bus that we get new message
 					// and subscribe to that event
-					go func(env, identifier string) {
-						ctx, cancel := context.WithTimeout(context.Background(), time.Second*60)
-						response, err := c.api.GetFeatureConfigByIdentifierWithResponse(ctx, env, identifier)
-						if err != nil {
-							c.logger.Errorf("error while pulling flag, err: %s", err.Error())
-							cancel()
-							return
-						}
-						if response.JSON200 != nil {
-							c.cache.Set(dto.Key{
+					switch cfMsg.Event {
+					case dto.SseDeleteEvent:
+						go func() {
+							c.cache.Remove(dto.Key{
 								Type: dto.KeyFeature,
 								Name: cfMsg.Identifier,
-							}, *response.JSON200.Convert())
-						}
-						cancel()
-					}(environment, cfMsg.Identifier)
+							})
+						}()
+
+					case dto.SsePatchEvent, dto.SseCreateEvent:
+						fallthrough
+					default:
+						go func(env, identifier string) {
+							ctx, cancel := context.WithTimeout(context.Background(), time.Second*60)
+							defer cancel()
+							response, err := c.api.GetFeatureConfigByIdentifierWithResponse(ctx, env, identifier)
+							if err != nil {
+								c.logger.Errorf("error while pulling flag, err: %s", err.Error())
+								return
+							}
+							if response.JSON200 != nil {
+								c.cache.Set(dto.Key{
+									Type: dto.KeyFeature,
+									Name: cfMsg.Identifier,
+								}, *response.JSON200.Convert())
+							}
+						}(environment, cfMsg.Identifier)
+					}
 				case dto.KeySegment:
 					// need open client spec change
 				}