nested prereqs need to compare with identifiers too

laura135 · laura135 · commit c636c182471f · 2022-11-03T16:43:39.000Z
diff --git a/evaluation/feature.go b/evaluation/feature.go
@@ -565,7 +565,7 @@ func checkPreReqsForPreReqs(preReqFlagPreReqs []Prerequisite, flags map[string]F
 		preReqVariationToMatch := nestedPreReq.Variations.FindByIdentifier(nestedPreReq.GetVariationName(target))
 		if preReq.Feature == nestedPreReq.Feature {
 			for _, variation := range preReq.Variations {
-				if variation != preReqVariationToMatch.Value {
+				if variation != preReqVariationToMatch.Identifier {
 					return false
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ func checkPreReqsForPreReqs(preReqFlagPreReqs []Prerequisite, flags map[string]F`
`565`	`565`	`preReqVariationToMatch := nestedPreReq.Variations.FindByIdentifier(nestedPreReq.GetVariationName(target))`
`566`	`566`	`if preReq.Feature == nestedPreReq.Feature {`
`567`	`567`	`for _, variation := range preReq.Variations {`
`568`		`- if variation != preReqVariationToMatch.Value {`
	`568`	`+ if variation != preReqVariationToMatch.Identifier {`
`569`	`569`	`return false`
`570`	`570`	`}`
`571`	`571`	`}`