Skip to content

Commit 0939d70

Browse files
author
Milos Vasic
committed
Merge remote-tracking branch 'origin/main' into main
2 parents 7511079 + 851c514 commit 0939d70

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ target
2020
.gradle
2121
build
2222

23-
*.iml
2423
.idea
25-
24+
*.iml
25+
gradle

src/main/java/io/harness/cf/client/Example.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
package io.harness.cf.client.example;
1+
package io.harness.cf.client;
22

33
import com.google.common.collect.ImmutableMap;
44
import io.harness.cf.client.api.CfClient;
55
import io.harness.cf.client.dto.Target;
66
import lombok.extern.slf4j.Slf4j;
77

88
@Slf4j
9-
public class Example {
9+
class Example {
1010

1111
public static final String FEATURE_FLAG_KEY = "toggle";
1212
public static final String API_KEY = "8b3bf1d0-6c88-4cdb-99a1-36aff131911a";

src/main/java/io/harness/cf/client/api/analytics/AnalyticsPublisherService.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.harness.cf.client.api.analytics;
22

3+
import com.google.common.base.Strings;
34
import io.harness.cf.client.api.CfClientException;
45
import io.harness.cf.client.api.Config;
56
import io.harness.cf.client.dto.Analytics;
@@ -122,8 +123,15 @@ private Metrics prepareMessageBody(Map<Analytics, Integer> all) {
122123
}
123124
targetData.addAttributesItem(keyValue);
124125
});
126+
125127
targetData.setIdentifier(target.getIdentifier());
126-
targetData.setName(target.getName());
128+
if (Strings.isNullOrEmpty(target.getName())) {
129+
130+
targetData.setName(target.getIdentifier());
131+
} else {
132+
133+
targetData.setName(target.getName());
134+
}
127135
metrics.addTargetDataItem(targetData);
128136
}
129137

src/main/java/io/harness/cf/client/dto/Target.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,22 @@
1919
@AllArgsConstructor
2020
@EqualsAndHashCode
2121
public class Target {
22-
private String identifier;
22+
2323
private String name;
24+
private String identifier;
25+
2426
@Default private Map<String, Object> attributes = new HashMap<>();
2527
private boolean isPrivate; // If the target is private
2628
private Set<String> privateAttributes; // Custom set to set the attributes which are private
2729

2830
@Override
2931
public String toString() {
32+
3033
return "TargetId: " + identifier;
3134
}
3235

3336
public boolean isValid() {
34-
return !Strings.isNullOrEmpty(name) && !Strings.isNullOrEmpty(identifier);
37+
38+
return !Strings.isNullOrEmpty(identifier);
3539
}
3640
}

0 commit comments

Comments
 (0)