Skip to content

Commit 371cde3

Browse files
committed
fix default pagination
1 parent de75da2 commit 371cde3

File tree

1 file changed

+22
-12
lines changed

1 file changed

+22
-12
lines changed

client/pipelines.go

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,21 @@ func (p *PipelineService) List(ctx context.Context, scope dto.Scope, opts *dto.P
4343
params := make(map[string]string)
4444
addScope(scope, params)
4545

46-
// Set default pagination and add pagination parameters if opts is provided
47-
if opts != nil {
48-
setDefaultPagination(&opts.PaginationOptions)
49-
params["page"] = fmt.Sprintf("%d", opts.Page)
50-
params["size"] = fmt.Sprintf("%d", opts.Size)
46+
// Handle nil options by creating default options
47+
if opts == nil {
48+
opts = &dto.PipelineListOptions{}
49+
}
5150

52-
// Add optional parameters if provided
53-
if opts.SearchTerm != "" {
54-
params["searchTerm"] = opts.SearchTerm
55-
}
51+
// Set default pagination
52+
setDefaultPagination(&opts.PaginationOptions)
53+
54+
// Add pagination parameters
55+
params["page"] = fmt.Sprintf("%d", opts.Page)
56+
params["size"] = fmt.Sprintf("%d", opts.Size)
57+
58+
// Add optional parameters if provided
59+
if opts.SearchTerm != "" {
60+
params["searchTerm"] = opts.SearchTerm
5661
}
5762

5863
// Create request body - this is required
@@ -73,13 +78,18 @@ func (p *PipelineService) List(ctx context.Context, scope dto.Scope, opts *dto.P
7378
}
7479

7580
func (p *PipelineService) ListExecutions(ctx context.Context, scope dto.Scope, opts *dto.PipelineExecutionOptions) (*dto.ListOutput[dto.PipelineExecution], error) {
76-
// Set default pagination
77-
setDefaultPagination(&opts.PaginationOptions)
78-
7981
// Prepare query parameters
8082
params := make(map[string]string)
8183
addScope(scope, params)
8284

85+
// Handle nil options by creating default options
86+
if opts == nil {
87+
opts = &dto.PipelineExecutionOptions{}
88+
}
89+
90+
// Set default pagination
91+
setDefaultPagination(&opts.PaginationOptions)
92+
8393
// Add pagination parameters
8494
params["page"] = fmt.Sprintf("%d", opts.Page)
8595
params["size"] = fmt.Sprintf("%d", opts.Size)

0 commit comments

Comments
 (0)