Skip to content

Commit 4778e4b

Browse files
Saranya-jenaHarness
authored andcommitted
chore: [ML-1397]: Extend the functionality to return last N lines of the log along with download file (#199)
* e36f79 chore: [ML-1397]: resolved comments * 26c96f chore: [ML-1397]: resolved comments * ecde95 Apply suggestion from code review * 27a20e Apply suggestion from code review * 117534 chore: [ML-1397]: updated branch * 33f6b6 chore: [ML-1397]: Resolved comments * 3ac384 chore: [ML-1397]: Resolved cooments * e7178b chore: [ML-1397]: Resolved cooments * f954d1 chore: [ML-1397]: Resolved cooments * c2b17d refactor: optimize memory usage by streaming ZIP file downloads instead of loading into memory * 123633 chore: [ML-1397]: extend the functionality to return last N lines of the log along with download file * aa2a5c Merge branch 'master' of https://git0.harness.io/l7B_kbSEQD2wjrM7PShm5w/PROD/Harness_Commons/mcp-server into ML-1397 * e8e1ad chore: [ML-1397]: extend the functionality to return last N lines of the log along with download file
1 parent 9561131 commit 4778e4b

File tree

2 files changed

+370
-14
lines changed

2 files changed

+370
-14
lines changed

client/logs.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ type LogService struct {
1919
PipelineClient *Client
2020
}
2121

22-
// DownloadLogs fetches a download URL for pipeline execution logs
22+
// GetDownloadLogsURL fetches a download URL for pipeline execution logs
2323
// If logKey is not empty, it will use that log key to fetch logs instead of building one from execution details
24-
func (l *LogService) DownloadLogs(ctx context.Context, scope dto.Scope, planExecutionID string, logKey string) (string, error) {
24+
func (l *LogService) GetDownloadLogsURL(ctx context.Context, scope dto.Scope, planExecutionID string, logKey string) (string, error) {
2525
// Use custom log key if provided, otherwise build it from execution details
2626
var finalLogKey string
2727
var err error

0 commit comments

Comments
 (0)