feat: [ML-1288]: implement module-specific prompt loading and registration system (#89)

* remove dead code

* Merge remote-tracking branch 'origin' into yogesh/module_prompts

* re-write

* refactor: reorganize module prompt handling with new DefaultModulePrompts mixin

* test: add prompt file loader tests and refactor file loading implementation

* refactor: simplify prompt loading by removing unused files and methods

* feat: add embedded filesystem support for prompt loading and update module prompts

* add back ccm text

* feat: [ML-1288]: implement module-specific prompt loading and registration system

Author: yogesh-chauhan

cmd/harness-mcp-server/main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"context"
 	"fmt"
-	"github.com/harness/harness-mcp/pkg/harness/prompts"
 	"io"
 	"log"
 	"log/slog"
@@ -15,6 +14,7 @@ import (
 	"github.com/harness/harness-mcp/cmd/harness-mcp-server/config"
 	"github.com/harness/harness-mcp/pkg/harness"
 	"github.com/harness/harness-mcp/pkg/harness/auth"
+	"github.com/harness/harness-mcp/pkg/modules"
 	"github.com/mark3labs/mcp-go/mcp"
 	"github.com/mark3labs/mcp-go/server"
 	"github.com/spf13/cobra"
@@ -374,8 +374,14 @@ func runStdioServer(ctx context.Context, config config.Config) error {
 	// Register the tools with the server
 	toolsets.RegisterTools(harnessServer)
 
-	// Set the guidelines prompts
-	prompts.RegisterPrompts(harnessServer)
+	// Create module registry
+	moduleRegistry := modules.NewModuleRegistry(&config, toolsets)
+
+	// Register prompts from all enabled modules
+	err = moduleRegistry.RegisterPrompts(harnessServer)
+	if err != nil {
+		return fmt.Errorf("failed to register module prompts: %w", err)
+	}
 
 	// Create stdio server
 	stdioServer := server.NewStdioServer(harnessServer)

go.mod

@@ -16,6 +16,7 @@ require (
 	github.com/spf13/cobra v1.8.0
 	github.com/spf13/viper v1.18.2
 	golang.org/x/tools v0.19.0
+	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (
@@ -54,5 +55,4 @@ require (
 	google.golang.org/appengine v1.6.7 // indirect
 	google.golang.org/protobuf v1.31.0 // indirect
 	gopkg.in/ini.v1 v1.67.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

pkg/harness/prompts/fetcher.go

@@ -0,0 +1,43 @@
+package prompts
+
+import (
+	"embed"
+)
+
+//go:embed files/**/*.txt
+var PromptFiles embed.FS // Exported to be accessible from other packages
+
+// GetModulePrompts retrieves prompts for a specific module from a given filesystem
+// GetModulePrompts retrieves prompts for a specific module from a given filesystem.
+// It loads common prompts from the "files/common" directory and mode-specific prompts
+// from the "files/internal" or "files/external" directory, depending on the value of `isInternal`.
+// It returns a slice of PromptFile containing the loaded prompts.
+func GetModulePrompts(fs embed.FS, module string, isInternal bool) ([]PromptFile, error) {
+	// Use embedded filesystem instead of file system paths
+	// Use the provided embedded filesystem
+	fileLoader := NewEmbedFileLoader(fs)
+
+	var allPrompts []PromptFile
+
+	// Load common prompt for the module directly
+	commonPath := "files/common/" + module + ".txt"
+	commonPrompt, err := fileLoader.loadPromptFileFromEmbed(commonPath)
+	if err == nil {
+		allPrompts = append(allPrompts, commonPrompt)
+	}
+
+	// Load mode-specific prompt for the module directly
+	var modePath string
+	if isInternal {
+		modePath = "files/internal/" + module + ".txt"
+	} else {
+		modePath = "files/external/" + module + ".txt"
+	}
+
+	modePrompt, err := fileLoader.loadPromptFileFromEmbed(modePath)
+	if err == nil {
+		allPrompts = append(allPrompts, modePrompt)
+	}
+
+	return allPrompts, nil
+}

pkg/harness/prompts/file_loader.go

@@ -0,0 +1,88 @@
+package prompts
+
+import (
+	"embed"
+	"fmt"
+	"strings"
+
+	"gopkg.in/yaml.v3"
+)
+
+// PromptMetadata represents the YAML frontmatter in prompt files
+type PromptMetadata struct {
+	Name              string `yaml:"name"`
+	Description       string `yaml:"description"`
+	ResultDescription string `yaml:"result_description"`
+	Module            string `yaml:"module"`
+}
+
+// PromptFile represents a loaded prompt file with metadata and content
+type PromptFile struct {
+	Metadata PromptMetadata
+	Content  string
+	FilePath string
+}
+
+// FileLoader handles loading prompts from text files
+type FileLoader struct {
+	embedFS embed.FS
+}
+
+// NewEmbedFileLoader creates a new file loader with embedded filesystem
+func NewEmbedFileLoader(embedFS embed.FS) *FileLoader {
+	return &FileLoader{
+		embedFS: embedFS,
+	}
+}
+
+// loadPromptFileFromEmbed loads a single prompt file from embedded filesystem with YAML frontmatter
+func (fl *FileLoader) loadPromptFileFromEmbed(filePath string) (PromptFile, error) {
+	data, err := fl.embedFS.ReadFile(filePath)
+	if err != nil {
+		return PromptFile{}, fmt.Errorf("failed to read embedded file: %w", err)
+	}
+
+	content := string(data)
+	lines := strings.Split(content, "\n")
+
+	var inFrontmatter bool
+	var frontmatterLines []string
+	var contentLines []string
+
+	for _, line := range lines {
+		if line == "---" {
+			if !inFrontmatter {
+				inFrontmatter = true
+				continue
+			} else {
+				inFrontmatter = false
+				continue
+			}
+		}
+
+		if inFrontmatter {
+			frontmatterLines = append(frontmatterLines, line)
+		} else if !inFrontmatter && len(frontmatterLines) > 0 {
+			contentLines = append(contentLines, line)
+		}
+	}
+
+	// Parse YAML frontmatter
+	var metadata PromptMetadata
+	if len(frontmatterLines) > 0 {
+		yamlContent := strings.Join(frontmatterLines, "\n")
+		if err := yaml.Unmarshal([]byte(yamlContent), &metadata); err != nil {
+			return PromptFile{}, fmt.Errorf("failed to parse YAML frontmatter: %w", err)
+		}
+	}
+
+	// Join content lines
+	fileContent := strings.Join(contentLines, "\n")
+	fileContent = strings.TrimSpace(fileContent)
+
+	return PromptFile{
+		Metadata: metadata,
+		Content:  fileContent,
+		FilePath: filePath,
+	}, nil
+}

pkg/harness/prompts/files/external/ccm.txt

@@ -0,0 +1,10 @@
+---
+name: "ccm"
+description: "Ensure parameters are provided correctly and in the right format"
+result_description: "Input parameters validation"
+---
+
+When calling get_ccm_overview, ensure you have: accountIdentifier, groupBy, startDate, and endDate.
+- If any are missing, ask the user for the specific value(s).
+- Always send startDate and endDate in the following format: 'MM/DD/YYYY' (e.g. '10/30/2025')
+- If no dates are supplied, default startDate to 60 days ago and endDate to now.

pkg/harness/prompts/files/internal/ccm.txt

@@ -0,0 +1,10 @@
+---
+name: "ccm"
+description: "Ensure parameters are provided correctly and in the right format"
+result_description: "Input parameters validation"
+---
+
+When calling get_ccm_overview, ensure you have: accountIdentifier, groupBy, startDate, and endDate.
+- If any are missing, ask the user for the specific value(s).
+- Always send startDate and endDate in the following format: 'MM/DD/YYYY' (e.g. '10/30/2025')
+- If no dates are supplied, default startDate to 60 days ago and endDate to now.

pkg/harness/prompts/prompts.go

@@ -10,6 +10,7 @@ func NewServer(version string, opts ...server.ServerOption) *server.MCPServer {
 	defaultOpts := []server.ServerOption{
 		server.WithToolCapabilities(true),
 		server.WithResourceCapabilities(true, true),
+		server.WithPromptCapabilities(true),
 		server.WithLogging(),
 	}
 	opts = append(defaultOpts, opts...)

pkg/harness/server.go

@@ -1,7 +1,6 @@
 package modules
 
 import (
-	"github.com/harness/harness-mcp/cmd/harness-mcp-server/config"
 	"github.com/harness/harness-mcp/pkg/toolsets"
 )
 
@@ -28,77 +27,6 @@ type Module interface {
 	IsDefault() bool
 }
 
-// ModuleRegistry holds all available modules
-type ModuleRegistry struct {
-	modules []Module
-	config  *config.Config
-	tsg     *toolsets.ToolsetGroup
-}
-
-// NewModuleRegistry creates a new module registry with all available modules
-func NewModuleRegistry(config *config.Config, tsg *toolsets.ToolsetGroup) *ModuleRegistry {
-	return &ModuleRegistry{
-		modules: []Module{
-			NewCoreModule(config, tsg),
-			NewCIModule(config, tsg),
-			NewCDModule(config, tsg),
-			NewUnlicensedModule(config, tsg),
-			NewCHAOSModule(config, tsg),
-			NewSEIModule(config, tsg),
-			NewSTOModule(config, tsg),
-			NewSSCAModule(config, tsg),
-			NewCODEModule(config, tsg),
-			NewCCMModule(config, tsg),
-			NewIDPModule(config, tsg),
-			NewHARModule(config, tsg),
-			NewDbOpsModule(config, tsg),
-		},
-		config: config,
-		tsg:    tsg,
-	}
-}
-
-// GetAllModules returns all available modules
-func (r *ModuleRegistry) GetAllModules() []Module {
-	return r.modules
-}
-
-// GetEnabledModules returns the list of enabled modules based on configuration
-func (r *ModuleRegistry) GetEnabledModules() []Module {
-	// Create a map for quick lookup of enabled module IDs
-	enabledModuleIDs := make(map[string]bool)
-	var defaultModules []Module
-	for _, module := range r.modules {
-		if module.IsDefault() {
-			defaultModules = append(defaultModules, module)
-			enabledModuleIDs[module.ID()] = true
-		}
-	}
-
-	// If no specific modules are enabled, return all default modules
-	if len(r.config.EnableModules) == 0 {
-		return defaultModules
-	}
-
-	for _, id := range r.config.EnableModules {
-		enabledModuleIDs[id] = true
-	}
-
-	// Check if "all" is enabled
-	if enabledModuleIDs["all"] {
-		return r.modules
-	}
-
-	// Return only enabled modules
-	var enabledModules []Module
-	for _, module := range r.modules {
-		if enabledModuleIDs[module.ID()] {
-			enabledModules = append(enabledModules, module)
-		}
-	}
-	return enabledModules
-}
-
 // ModuleEnableToolsets is a helper function that safely enables toolsets
 // by only enabling toolsets that actually exist in the toolset group
 func ModuleEnableToolsets(m Module, tsg *toolsets.ToolsetGroup) error {
@@ -116,5 +44,7 @@ func ModuleEnableToolsets(m Module, tsg *toolsets.ToolsetGroup) error {
 	if len(existingToolsets) == 0 {
 		return nil
 	}
+
+	// Enable the toolsets
 	return tsg.EnableToolsets(existingToolsets)
 }