download logs completely instead of just returning the URL

Author: vistaarjuneja

pkg/harness/logs.go

@@ -3,21 +3,31 @@ package harness
 import (
 	"context"
 	"fmt"
+	"io"
+	"net/http"
+	"os"
+	"path/filepath"
 
 	"github.com/harness/harness-mcp/client"
 	"github.com/harness/harness-mcp/cmd/harness-mcp-server/config"
 	"github.com/mark3labs/mcp-go/mcp"
 	"github.com/mark3labs/mcp-go/server"
 )
 
-// FetchLogDownloadURLTool creates a tool for fetching log download URLs for pipeline executions
-func FetchLogDownloadURLTool(config *config.Config, client *client.Client) (tool mcp.Tool, handler server.ToolHandlerFunc) {
-	return mcp.NewTool("fetch_log_download_url",
-			mcp.WithDescription("Fetch the download URL for pipeline execution logs in Harness."),
+// DownloadExecutionLogsTool creates a tool for downloading logs for a pipeline execution
+// TODO: to make this easy to use, we ask to pass in an output path and do the complete download of the logs.
+// This is less work for the user, but we may want to only return the download instruction instead in the future.
+func DownloadExecutionLogsTool(config *config.Config, client *client.Client) (tool mcp.Tool, handler server.ToolHandlerFunc) {
+	return mcp.NewTool("download_execution_logs",
+			mcp.WithDescription("Downloads logs for an execution inside Harness"),
 			mcp.WithString("plan_execution_id",
 				mcp.Required(),
 				mcp.Description("The ID of the plan execution"),
 			),
+			mcp.WithString("logs_directory",
+				mcp.Required(),
+				mcp.Description("The absolute path to the directory where the logs should get downloaded"),
+			),
 			WithScope(config, true),
 		),
 		func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
@@ -36,7 +46,64 @@ func FetchLogDownloadURLTool(config *config.Config, client *client.Client) (tool
 				return nil, fmt.Errorf("failed to fetch log download URL: %w", err)
 			}
 
-			instruction := fmt.Sprintf("You can use the command \"curl -o logs.zip %s\" to download the zip for the logs.", logDownloadURL)
+			logsDirectory, err := requiredParam[string](request, "logs_directory")
+			if err != nil {
+				return mcp.NewToolResultError(err.Error()), nil
+			}
+
+			// Check if logs directory exists, if not create it
+			_, err = os.Stat(logsDirectory)
+			if err != nil {
+				createErr := os.Mkdir(logsDirectory, 0755)
+				if createErr != nil {
+					return mcp.NewToolResultError(createErr.Error()), nil
+				}
+			}
+
+			// Create the logs folder with plan execution ID
+			logsFolderName := fmt.Sprintf("logs-%s", planExecutionID)
+			logsFolderPath := filepath.Join(logsDirectory, logsFolderName)
+
+			err = os.Mkdir(logsFolderPath, 0755)
+			if err != nil {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to create logs folder: %v", err)), nil
+			}
+
+			// Get the download URL
+			logDownloadURL, err = client.Logs.DownloadLogs(ctx, scope, planExecutionID)
+			if err != nil {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to fetch log download URL: %v", err)), nil
+			}
+
+			// Download the logs into outputPath
+			resp, err := http.Get(logDownloadURL)
+			if err != nil {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to download logs: %v", err)), nil
+			}
+			defer resp.Body.Close()
+
+			if resp.StatusCode != http.StatusOK {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to download logs: unexpected status code %d", resp.StatusCode)), nil
+			}
+
+			// Create the logs.zip file path
+			logsZipPath := filepath.Join(logsFolderPath, "logs.zip")
+
+			// Create the output file
+			outputFile, err := os.Create(logsZipPath)
+			if err != nil {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to create output file: %v", err)), nil
+			}
+			defer outputFile.Close()
+
+			// Copy the response body to the output file
+			bytesWritten, err := io.Copy(outputFile, resp.Body)
+			if err != nil {
+				return mcp.NewToolResultError(fmt.Sprintf("failed to write logs to file: %v", err)), nil
+			}
+
+			// Success message with download details
+			instruction := fmt.Sprintf("Successfully downloaded logs to %s (%d bytes)! You can unzip and analyze these logs.", logsZipPath, bytesWritten)
 
 			return mcp.NewToolResultText(instruction), nil
 		}

pkg/harness/tools.go

@@ -44,7 +44,7 @@ func InitToolsets(client *client.Client, config *config.Config) (*toolsets.Tools
 	// Create the logs toolset
 	logs := toolsets.NewToolset("logs", "Harness Logs related tools").
 		AddReadTools(
-			toolsets.NewServerTool(FetchLogDownloadURLTool(config, client)),
+			toolsets.NewServerTool(DownloadExecutionLogsTool(config, client)),
 		)
 
 	// Add toolsets to the group