fix: [ML-1391]: Fixed issue with occasional failure in download_execution_logs due to pre-existing empty logs directory (#209)

* b92fc4 chore: [ML-1395]: Resolved comments

* 5ead1b refactor: simplify log directory creation by removing redundant MkdirAll call (#211)

* 97ea96 Merge branch 'master' of https://git0.harness.io/l7B_kbSEQD2wjrM7PShm5w/PROD/Harness_Commons/mcp-server into ML-1391

* e3d057 chore: [ML-1391]: Resolved comments

* c95a74 fix: [ML-1391]: Fixed issue with occasional failure in download_execution_logs due to pre-existing empty logs directory

Author: Saranya-jena

pkg/harness/tools/logs.go

@@ -57,27 +57,12 @@ func DownloadExecutionLogsTool(config *config.Config, client *client.LogService)
 				return mcp.NewToolResultError(err.Error()), nil
 			}
 
-			// Check if logs directory exists, if not create it
-			_, err = os.Stat(logsDirectory)
-			if err != nil {
-				// Directory does not exist, create it
-				if os.IsNotExist(err) {
-					createErr := os.Mkdir(logsDirectory, 0755)
-					if createErr != nil {
-						return mcp.NewToolResultError(createErr.Error()), nil
-					}
-				} else {
-					return mcp.NewToolResultError(err.Error()), nil
-				}
-			}
-
-			// Create the logs folder with plan execution ID
+			// Create the logs folder path (creates all parent directories if needed)
 			logsFolderName := fmt.Sprintf("logs-%s", planExecutionID)
 			logsFolderPath := filepath.Join(logsDirectory, logsFolderName)
-
-			err = os.Mkdir(logsFolderPath, 0755)
+			err = os.MkdirAll(logsFolderPath, 0755)
 			if err != nil {
-				return mcp.NewToolResultError(fmt.Sprintf("failed to create logs folder: %v", err)), nil
+				return mcp.NewToolResultError(fmt.Sprintf("failed to create logs directory: %v", err)), nil
 			}
 
 			// Get the download URL