Skip to content

Commit ec9966d

Browse files
vistaarjunejaHarness
authored andcommitted
Add rules for AI auto review to follow (#70)
* add auto review rules
1 parent 4f2c4a0 commit ec9966d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.harness/rules/review.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
1. Ensure the names of tools are not ambiguous and do not conflict with existing names
2+
2. Ensure the descriptions are clear and suggest better descriptions if not well written. Ensure descriptions are not ambiguous.
3+
3. Analyze the parameters for the tools and look for parameters which are machine data that will be hard for LLMs to interpret
4+
4. Whenever you see request parameter fields in tool handlers which are strings with defined values, suggest to use `mcp.Enum` to track those.
5+
5. Make sure we use defined methods like `mcp.NewToolResultError` to return errors from functions that return `mcp.CallToolRequest`

0 commit comments

Comments
 (0)