feat: Various improvements to WhatTheStackActivity

- Remove kotlin synthetics
- Use kotlin 1.4 stacktraceToString method
- Fix system insets on vertical edges
- Enable a horizontally scrolling stacktrace

Author: haroldadmin

build.gradle

@@ -18,7 +18,7 @@ buildscript {
             "materialComponents": "1.1.0",
             "fragment"          : "1.2.4",
             "constraintLayout"  : "1.1.3",
-            "insetter"          : "0.2.2",
+            "insetter"          : "0.3.1",
             "junit"             : "4.12",
             "androidxTestCore"  : "1.2.0",
             "androidxTestExt"   : "1.1.1",

what-the-stack/build.gradle

@@ -33,10 +33,6 @@ android {
         targetCompatibility JavaVersion.VERSION_1_8
     }
 
-    androidExtensions {
-        experimental = true
-    }
-
     kotlin {
         explicitApi()
     }

what-the-stack/src/main/java/com/haroldadmin/whatthestack/ExceptionProcessor.kt

@@ -29,7 +29,7 @@ internal fun Throwable.process(): ExceptionData {
     val rootCauseOfException = rootCause()
     val cause = rootCauseOfException.type()
     val message = rootCauseOfException.message ?: "Unknown"
-    val stacktrace = rootCauseOfException.stacktrace()
+    val stacktrace = this.stackTraceToString()
     return ExceptionData(type, cause, message, stacktrace)
 }
 
@@ -53,12 +53,3 @@ internal tailrec fun Throwable.rootCause(): Throwable {
 internal fun Throwable.type(): String {
     return this::class.java.simpleName
 }
-
-/**
- * Returns the stacktrace of the exception in the form of a string.
- */
-internal fun Throwable.stacktrace(): String {
-    val outputStream = StringOutputStream()
-    printStackTrace(PrintStream(outputStream))
-    return outputStream.getString()
-}

what-the-stack/src/main/java/com/haroldadmin/whatthestack/WhatTheStackActivity.kt

@@ -4,10 +4,16 @@ import android.content.ClipData
 import android.content.ClipboardManager
 import android.content.Context
 import android.os.Bundle
+import android.text.method.ScrollingMovementMethod
 import android.view.View
+import android.widget.TextView
 import androidx.appcompat.app.AppCompatActivity
+import androidx.appcompat.widget.AppCompatTextView
 import androidx.core.view.updatePadding
+import com.google.android.material.button.MaterialButton
 import com.google.android.material.snackbar.Snackbar
+import dev.chrisbanes.insetter.Insetter
+import dev.chrisbanes.insetter.Side
 import dev.chrisbanes.insetter.doOnApplyWindowInsets
 import kotlinx.android.synthetic.main.activity_what_the_stack.*
 
@@ -25,31 +31,42 @@ class WhatTheStackActivity : AppCompatActivity() {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_what_the_stack)
 
-        nestedScrollRoot.apply {
-            systemUiVisibility = (View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION
-                    or View.SYSTEM_UI_FLAG_LAYOUT_STABLE)
+        window.decorView.systemUiVisibility =
+            View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION or View.SYSTEM_UI_FLAG_LAYOUT_STABLE
 
-            doOnApplyWindowInsets { view, insets, initialState ->
-                view.updatePadding(
-                        top = initialState.paddings.top + insets.systemWindowInsetTop
-                )
-            }
-        }
+        Insetter.builder()
+            .applySystemWindowInsetsToPadding(Side.LEFT or Side.RIGHT or Side.TOP)
+            .applyToView(findViewById(R.id.nestedScrollRoot))
 
         val type = intent.getStringExtra(KEY_EXCEPTION_TYPE)
         val cause = intent.getStringExtra(KEY_EXCEPTION_CAUSE)
         val message = intent.getStringExtra(KEY_EXCEPTION_MESSAGE)
         val stackTrace = intent.getStringExtra(KEY_EXCEPTION_STACKTRACE)
 
-        stacktrace.text = stackTrace
-        exceptionName.text = getString(R.string.exception_name, type)
-        exceptionCause.text = getString(R.string.exception_cause, cause)
-        exceptionMessage.text = getString(R.string.exception_message, message)
+        findViewById<TextView>(R.id.stacktrace).apply {
+            text = stackTrace
+            setHorizontallyScrolling(true)
+            movementMethod = ScrollingMovementMethod()
+        }
+
+        findViewById<AppCompatTextView>(R.id.exceptionName).apply {
+            text = getString(R.string.exception_name, type)
+        }
+
+        findViewById<AppCompatTextView>(R.id.exceptionCause).apply {
+            text = getString(R.string.exception_cause, cause)
+        }
 
-        copyStacktrace.setOnClickListener {
-            val clipping = ClipData.newPlainText("stacktrace", stackTrace)
-            clipboardManager.setPrimaryClip(clipping)
-            snackbar { R.string.copied_message }
+        findViewById<AppCompatTextView>(R.id.exceptionMessage).apply {
+            text = getString(R.string.exception_message, message)
+        }
+
+        findViewById<MaterialButton>(R.id.copyStacktrace).apply {
+            setOnClickListener {
+                val clipping = ClipData.newPlainText("stacktrace", stackTrace)
+                clipboardManager.setPrimaryClip(clipping)
+                snackbar { R.string.copied_message }
+            }
         }
     }
 

what-the-stack/src/main/res/layout/activity_what_the_stack.xml

@@ -103,7 +103,6 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:fontFamily="monospace"
-                android:scrollHorizontally="true"
                 android:textAppearance="?attr/textAppearanceBody2"
                 android:textColor="?attr/colorError"
                 tools:text="@string/sample_stack_trace" />

what-the-stack/src/test/java/com/haroldadmin/whatthestack/ExceptionProcessingTest.kt

@@ -35,7 +35,7 @@ internal class ExceptionProcessingTest {
         val outputStream = StringOutputStream()
         exception.printStackTrace(PrintStream(outputStream))
 
-        assert(outputStream.getString() == exception.stacktrace())
+        assert(outputStream.getString() == exception.stackTraceToString())
     }
 
     @Test
@@ -45,7 +45,7 @@ internal class ExceptionProcessingTest {
 
         assert(processedData.type == exception.type())
         assert(processedData.message == exception.rootCause().message)
-        assert(processedData.stacktrace == exception.rootCause().stacktrace())
+        assert(processedData.stacktrace == exception.stackTraceToString())
         assert(processedData.cause == exception.rootCause().type())
     }
 }