literature: display authors with no hepnames records

* INSPIR-3163
ui: display bai in author profile

* INSPIR-2735
* Needs reindexing of literature

Author: monaawi

backend/inspirehep/records/marshmallow/authors/ui.py

@@ -5,10 +5,9 @@
 # inspirehep is free software; you can redistribute it and/or modify it under
 # the terms of the MIT License; see LICENSE file for more details.
 
-from inspire_utils.record import get_values_for_schema
 from marshmallow import fields
 
-from ..utils import get_facet_author_name_for_author
+from ..utils import get_facet_author_name_for_author, get_id_for_schema
 from .base import AuthorsPublicSchema
 from .common import PositionSchemaV1
 
@@ -38,17 +37,21 @@ def get_facet_author_name(self, data):
             return get_facet_author_name_for_author(data)
         return facet_author_name
 
-    def get_twitter(self, data):
-        return self.get_id_for_schema(data, "TWITTER")
+    @staticmethod
+    def get_twitter(data):
+        return get_id_for_schema(data, "TWITTER")
 
-    def get_linkedin(self, data):
-        return self.get_id_for_schema(data, "LINKEDIN")
+    @staticmethod
+    def get_linkedin(data):
+        return get_id_for_schema(data, "LINKEDIN")
 
-    def get_orcid(self, data):
-        return self.get_id_for_schema(data, "ORCID")
+    @staticmethod
+    def get_orcid(data):
+        return get_id_for_schema(data, "ORCID")
 
-    def get_bai(self, data):
-        return self.get_id_for_schema(data, "INSPIRE BAI")
+    @staticmethod
+    def get_bai(data):
+        return get_id_for_schema(data, "INSPIRE BAI")
 
     @staticmethod
     def get_current_public_emails(data):
@@ -59,12 +62,6 @@ def get_current_public_emails(data):
             if not email.get("hidden") and email.get("current")
         ]
 
-    @staticmethod
-    def get_id_for_schema(data, schema):
-        ids = data.get("ids", [])
-        ids_for_schema = get_values_for_schema(ids, schema)
-        return ids_for_schema[0] if ids_for_schema else None
-
     @staticmethod
     def get_should_display_positions(data):
         positions = data.get("positions")

backend/inspirehep/records/marshmallow/literature/common/author.py

@@ -11,6 +11,8 @@
 from inspire_utils.name import generate_name_variations
 from marshmallow import Schema, fields, missing, pre_dump
 
+from inspirehep.records.marshmallow.utils import get_id_for_schema
+
 
 class AuthorSchemaV1(Schema):
 
@@ -29,6 +31,11 @@ class AuthorSchemaV1(Schema):
     uuid = fields.Raw()
     first_name = fields.Method("get_first_name", default=missing)
     last_name = fields.Method("get_last_name", default=missing)
+    bai = fields.Method("get_bai", dump_only=True)
+
+    @staticmethod
+    def get_bai(data):
+        return get_id_for_schema(data, "INSPIRE BAI") or missing
 
     def get_first_name(self, data):
         names = data.get("full_name", "").split(",", 1)

backend/inspirehep/records/marshmallow/utils.py

@@ -6,7 +6,7 @@
 # the terms of the MIT License; see LICENSE file for more details.
 
 from inspire_utils.name import ParsedName
-from inspire_utils.record import get_value
+from inspire_utils.record import get_value, get_values_for_schema
 
 
 def get_display_name_for_author_name(author_name):
@@ -22,3 +22,9 @@ def get_facet_author_name_for_author(author):
         return f"{author_control_number}_{author_preferred_name}"
 
     return f"{author_control_number}_{get_display_name_for_author_name(get_value(author, 'name.value'))}"
+
+
+def get_id_for_schema(data, schema):
+    ids = data.get("ids", [])
+    ids_for_schema = get_values_for_schema(ids, schema)
+    return ids_for_schema[0] if ids_for_schema else None

backend/tests/integration/records/indexer/test_indexer_literature/es_1630825.json

@@ -38,6 +38,24 @@ def test_author_without_last_name():
     assert expected == json.loads(result)
 
 
+def test_author_with_bai():
+    schema = AuthorSchemaV1()
+
+    dump = {
+        "full_name": "Frank Castle",
+        "ids": [{"schema": "INSPIRE BAI", "value": "Frank.Castle.1"}],
+    }
+    expected = {
+        "full_name": "Frank Castle",
+        "first_name": "Frank Castle",
+        "bai": "Frank.Castle.1",
+        "ids": [{"schema": "INSPIRE BAI", "value": "Frank.Castle.1"}],
+    }
+    result = schema.dumps(dump).data
+
+    assert expected == json.loads(result)
+
+
 def test_author_with_with_inspire_roles():
     schema = AuthorSchemaV1()
     dump = {"full_name": "Smith, John", "inspire_roles": ["author"]}

backend/tests/unit/records/marshmallow/literature/common/test_author.py

@@ -0,0 +1,19 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Link } from 'react-router-dom';
+import { getLiteratureSearchUrlForAuthorBAI } from '../../common/utils';
+
+function AuthorBAI({ bai }) {
+  return (
+    <span>
+      Author Identifier:{' '}
+      <Link to={getLiteratureSearchUrlForAuthorBAI(bai)}>{bai}</Link>
+    </span>
+  );
+}
+
+AuthorBAI.propTypes = {
+  bai: PropTypes.string.isRequired,
+};
+
+export default AuthorBAI;

ui/src/authors/components/AuthorBAI.jsx

@@ -0,0 +1,10 @@
+import React from 'react';
+import { shallow } from 'enzyme';
+import AuthorBAI from '../AuthorBAI';
+
+describe('AuthorBAI', () => {
+  it('renders', () => {
+    const wrapper = shallow(<AuthorBAI bai="F.Marchetto.1" />);
+    expect(wrapper).toMatchSnapshot();
+  });
+});

ui/src/authors/components/__tests__/AuthorBAI.test.jsx

@@ -0,0 +1,14 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AuthorBAI renders 1`] = `
+<span>
+  Author Identifier:
+   
+  <Link
+    replace={false}
+    to="/literature?q=a%20F.Marchetto.1"
+  >
+    F.Marchetto.1
+  </Link>
+</span>
+`;

ui/src/authors/components/__tests__/__snapshots__/AuthorBAI.test.jsx.snap

@@ -39,6 +39,7 @@ import EditRecordAction from '../../common/components/EditRecordAction';
 import DeletedAlert from '../../common/components/DeletedAlert';
 import UserSettingsAction from '../components/UserSettingsAction';
 import withRouteActionsDispatcher from '../../common/withRouteActionsDispatcher';
+import AuthorBAI from '../components/AuthorBAI';
 
 function renderNumberOfCiteablePapers(value) {
   return (
@@ -95,6 +96,7 @@ function DetailPage({
   const orcid = metadata.get('orcid');
   const emails = metadata.get('email_addresses');
   const deleted = metadata.get('deleted', false);
+  const bai = metadata.get('bai');
 
   const metaDescription = useMemo(() => getAuthorMetaDescription(metadata), [
     metadata,
@@ -157,6 +159,7 @@ function DetailPage({
                   <Col xs={24} lg={12} className="mb3">
                     <ArxivCategoryList arxivCategories={arxivCategories} />
                     <ExperimentList experiments={experiments} />
+                    {bai && <AuthorBAI bai={bai} />}
                   </Col>
                   <Col xs={24} lg={12}>
                     {shouldDisplayPositions && (

ui/src/authors/containers/DetailPageContainer.jsx

@@ -21,6 +21,7 @@ import pluralizeUnlessSingle, {
   downloadTextAsFile,
   addOrdinalSuffix,
   makeCompliantMetaDescription,
+  getAuthorName,
 } from '../utils';
 
 describe('utils', () => {
@@ -313,7 +314,7 @@ describe('utils', () => {
         error: {
           status: 500,
           foo: 'bar',
-        }
+        },
       };
       expect(result).toEqual(expected);
     });
@@ -328,7 +329,7 @@ describe('utils', () => {
       const expected = {
         error: {
           status: 500,
-        }
+        },
       };
       expect(result).toEqual(expected);
     });
@@ -341,7 +342,7 @@ describe('utils', () => {
       const expected = {
         error: {
           status: 'network',
-        }
+        },
       };
       expect(result).toEqual(expected);
     });
@@ -614,21 +615,51 @@ describe('utils', () => {
 
   describe('makeCompliantMetaDescription', () => {
     it('strips html tags and truncates to 160 chars', () => {
-      const input = 'Lorem <strong>ipsum</strong> dolor sit <a href="/link">amet</a>, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.';
-      const expectedOutput = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nos...'
-      const output = makeCompliantMetaDescription(input)
+      const input =
+        'Lorem <strong>ipsum</strong> dolor sit <a href="/link">amet</a>, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.';
+      const expectedOutput =
+        'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nos...';
+      const output = makeCompliantMetaDescription(input);
       expect(output).toEqual(expectedOutput);
     });
 
     it('does not do anything if input does not include any html tags and shorter than 160 chars', () => {
       const input = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.';
-      const output = makeCompliantMetaDescription(input)
+      const output = makeCompliantMetaDescription(input);
       expect(output).toEqual(input);
     });
 
     it('returns empty if undefine is passed', () => {
-      const output = makeCompliantMetaDescription(undefined)
+      const output = makeCompliantMetaDescription(undefined);
       expect(output).toEqual('');
     });
   });
+
+  describe('getAuthorName', () => {
+    it('returns first name and last name', () => {
+      const author = fromJS({
+        full_name: 'Name, Full',
+        first_name: 'Full',
+        last_name: 'Name',
+      });
+      const output = getAuthorName(author);
+      expect(output).toEqual('Full Name');
+    });
+    it('returns full name if first name is missing', () => {
+      const author = fromJS({
+        full_name: 'Name, Full',
+        last_name: 'Name',
+      });
+      const output = getAuthorName(author);
+      expect(output).toEqual('Name, Full');
+    });
+    it('returns first name if last name is missing', () => {
+      const author = fromJS({
+        full_name: 'Name, Full',
+        first_name: 'Name',
+      });
+      const output = getAuthorName(author);
+      expect(output).toEqual('Name ');
+    });
+  });
 });