records: remove previous version exception

Author: drjova

backend/inspirehep/records/api/base.py

@@ -22,6 +22,7 @@
 from invenio_records.models import RecordMetadata
 from sqlalchemy import tuple_
 from sqlalchemy.orm.attributes import flag_modified
+from sqlalchemy.orm.exc import NoResultFound
 
 from inspirehep.indexer.base import InspireRecordIndexer
 from inspirehep.pidstore.api import PidStoreBase
@@ -395,11 +396,20 @@ def index(self, force_delete=None, delay=True):
     @property
     def _previous_version(self):
         """Returns the previous version of the record"""
-        current = self.model.versions.filter_by(version_id=self.model.version_id).one()
-        if current.previous:
-            data = current.previous.json
-        else:
-            data = {}
+        data = {}
+        try:
+            current = self.model.versions.filter_by(
+                version_id=self.model.version_id
+            ).one()
+            if current.previous:
+                data = current.previous.json
+        except NoResultFound:
+            LOGGER.warning(
+                "Record previous version is not found",
+                version_id=self.model.version_id,
+                uuid=self.id,
+            )
+
         return type(self)(data=data)
 
     @property

backend/tests/integration-async/records/api/test_base.py

@@ -41,6 +41,23 @@ def test_record_versioning(app, clear_environment):
     assert record._previous_version
 
 
+def test_record_previous_version_doesnt_fail_if_previous_version_missing(
+    app, clear_environment
+):
+    data = {
+        "$schema": "http://localhost:5000/schemas/records/hep.json",
+        "titles": [{"title": "Test a valid record"}],
+        "document_type": ["article"],
+        "_collections": ["Literature"],
+    }
+
+    expected_version_created = 1
+    expected_count_created = 1
+    record = LiteratureRecord.create(data)
+    record_control_number = record["control_number"]
+    assert LiteratureRecord({}) == record._previous_version
+
+
 def test_get_modified_references_returns_all_references_when_earliest_date_changed(
     app, clear_environment
 ):