Enable longhorn storage reserved percentage conf (#1133)

Enabling storage-reserved-percentage-for-default-disk configuration
as part of the install.harvester.longhorn.defaultSettings

The following behaviour is enforced:
* values can range between 0% and 30%
* default value if no config passed is 0%
* max value is 30%

Signed-off-by: Martin Dekov <martin.dekov@suse.com>

Author: martindekov

pkg/config/config.go

@@ -123,6 +123,8 @@ type LHDefaultSettings struct {
 	// from Longhorn v1.5.0, LH merges the above two into one
 	// the above two are not used afterwards, but Harvester keeps them for compatibility
 	GuaranteedInstanceManagerCPU *uint32 `json:"guaranteedInstanceManagerCPU,omitempty"`
+
+	StorageReservedPercentageForDefaultDisk *uint32 `json:"storageReservedPercentageForDefaultDisk,omitempty"`
 }
 
 type LonghornChartValues struct {

pkg/config/cos.go

@@ -28,12 +28,15 @@ const (
 	ifcfgGlobPattern       = networkConfigDirectory + "ifcfg-*"
 	ifrouteGlobPattern     = networkConfigDirectory + "ifroute-*"
 
-	bootstrapConfigCount                = 6
-	defaultReplicaCount                 = 3
-	defaultGuaranteedEngineManagerCPU   = 12   // means percentage 12%
-	defaultGuaranteedReplicaManagerCPU  = 12   // means percentage 12%
-	defaultGuaranteedInstanceManagerCPU = 12   // means percentage 12%
-	defaultSystemImageSize              = 3072 // size of /run/initramfs/cos-state/cOS/active.img in MB
+	bootstrapConfigCount                           = 6
+	defaultReplicaCount                            = 3
+	defaultGuaranteedEngineManagerCPU              = 12   // means percentage 12%
+	defaultGuaranteedReplicaManagerCPU             = 12   // means percentage 12%
+	defaultGuaranteedInstanceManagerCPU            = 12   // means percentage 12%
+	defaultStorageReservedPercentageForDefaultDisk = 0    // means percentage 0%
+	defaultSystemImageSize                         = 3072 // size of /run/initramfs/cos-state/cOS/active.img in MB
+
+	maxStorageReservedPercentageForDefaultDisk = 30 // means percentage 30%
 )
 
 var (
@@ -302,6 +305,15 @@ func setConfigDefaultValues(config *HarvesterConfig) {
 	if config.Harvester.Longhorn.DefaultSettings.GuaranteedInstanceManagerCPU != nil && *config.Harvester.Longhorn.DefaultSettings.GuaranteedInstanceManagerCPU > defaultGuaranteedInstanceManagerCPU {
 		*config.Harvester.Longhorn.DefaultSettings.GuaranteedInstanceManagerCPU = defaultGuaranteedInstanceManagerCPU
 	}
+
+	if config.Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk != nil {
+		if *config.Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk > maxStorageReservedPercentageForDefaultDisk {
+			*config.Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk = maxStorageReservedPercentageForDefaultDisk
+		}
+	} else {
+		config.Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk = new(uint32)
+		*config.Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk = uint32(defaultStorageReservedPercentageForDefaultDisk)
+	}
 }
 
 func initRancherdStage(config *HarvesterConfig, stage *yipSchema.Stage) error {

pkg/config/templates/rancherd-10-harvester.yaml

@@ -185,6 +185,9 @@ resources:
           {{- if .Harvester.Longhorn.DefaultSettings.GuaranteedInstanceManagerCPU }}
           guaranteedInstanceManagerCPU: {{ .Harvester.Longhorn.DefaultSettings.GuaranteedInstanceManagerCPU }}
           {{- end }}
+          {{- if .Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk }}
+          storageReservedPercentageForDefaultDisk: {{ .Harvester.Longhorn.DefaultSettings.StorageReservedPercentageForDefaultDisk }}
+          {{- end }}
           detachManuallyAttachedVolumesWhenCordoned: true
           nodeDrainPolicy: "allow-if-replica-is-stopped"
       harvester-network-controller: