Update pkg/controller/virtualmachine/virtualmachine.go

Jeremy Liu · Yu-Jack · ibrokethecloud · commit f31454ee2d51 · 2025-09-05T15:33:34.000+10:00
Co-authored-by: Jack Yu &lt;jack.yu@suse.com&gt;
Signed-off-by: Jeremy Liu &lt;liujiong63@163.com&gt;
diff --git a/pkg/controller/virtualmachine/virtualmachine.go b/pkg/controller/virtualmachine/virtualmachine.go
@@ -368,9 +368,8 @@ func (h *Handler) OnVMIDeletion(_ string, vmi *kubevirtv1.VirtualMachineInstance
 		if k8serrors.IsNotFound(err) {
 			// vm is deleted
 			return vmi, nil
-		} else {
-			return vmi, fmt.Errorf("error fetching vm object for vmi %s/%s: %v", vmi.Namespace, vmi.Name, err)
 		}
+		return vmi, fmt.Errorf("error fetching vm object for vmi %s/%s: %v", vmi.Namespace, vmi.Name, err)
 	}
 	if vmObj.DeletionTimestamp != nil {
 		return vmi, nil

Original file line number	Diff line number	Diff line change
`@@ -368,9 +368,8 @@ func (h Handler) OnVMIDeletion(_ string, vmi kubevirtv1.VirtualMachineInstance`
`368`	`368`	`if k8serrors.IsNotFound(err) {`
`369`	`369`	`// vm is deleted`
`370`	`370`	`return vmi, nil`
`371`		`- } else {`
`372`		`- return vmi, fmt.Errorf("error fetching vm object for vmi %s/%s: %v", vmi.Namespace, vmi.Name, err)`
`373`	`371`	`}`
	`372`	`+ return vmi, fmt.Errorf("error fetching vm object for vmi %s/%s: %v", vmi.Namespace, vmi.Name, err)`
`374`	`373`	`}`
`375`	`374`	`if vmObj.DeletionTimestamp != nil {`
`376`	`375`	`return vmi, nil`