feat: Remove lineProfile page (#1842)

Author: arielvino

CLAUDE.md

@@ -101,7 +101,6 @@ src/
 │   ├── dashboard/          # Analytics dashboard with charts
 │   ├── gaps/               # Service gap visualization
 │   ├── gapsPatterns/       # Gap-patterns analysis
-│   ├── lineProfile/        # Individual line details
 │   ├── operator/           # Operator performance
 │   ├── singleLineMap/      # Single line on the map
 │   ├── stationStops/       # Planned vs. actual stop times at one stop

src/api/gtfsService.ts

@@ -100,31 +100,6 @@ export async function getGtfsStopHitTimesAsync(stop: BusStop, time: dayjs.Dayjs)
   }
 }
 
-export async function getRouteById(routeId?: string, signal?: AbortSignal) {
-  try {
-    if (!routeId?.trim()) {
-      throw new Error('Route id is required and cannot be empty')
-    }
-    const id = Number(routeId)
-    if (!Number.isInteger(id) || id <= 0 || id > Number.MAX_SAFE_INTEGER) {
-      throw new Error(`Invalid route id: ${routeId}.`)
-    }
-    return await GTFS_API.gtfsRoutesGetGet({ id }, { signal })
-  } catch (error) {
-    let errorMessage: string
-    if (error instanceof Error) {
-      errorMessage =
-        error.message === 'Response returned an error code'
-          ? `Route with id ${routeId} not found`
-          : error.message
-    } else {
-      errorMessage = 'An unexpected error occurred while fetching route data'
-    }
-    console.error(`Failed to get route ${routeId}:`, errorMessage)
-    throw new Error(errorMessage)
-  }
-}
-
 export async function getAllRoutesList(operatorId: string, date: CivilDate, signal?: AbortSignal) {
   return await GTFS_API.gtfsRoutesListGet(
     {

src/layout/header/shareUrl.test.ts

@@ -208,32 +208,3 @@ describe('buildShareUrl — per-page param contracts', () => {
     })
   }
 })
-
-// ---------------------------------------------------------------------------
-// buildShareUrl — dynamic profile path
-// ---------------------------------------------------------------------------
-
-// /profile/:id is not in PAGE_SHARE_PARAMS. The route ID is already in the
-// path, so GlobalSearchContext params must not leak into the URL — only explicit
-// page params (e.g. rideTime) registered via PageShareParamsContext appear.
-
-describe('buildShareUrl — dynamic profile path', () => {
-  it('no GlobalSearchContext params leak into the URL', () => {
-    const p = paramsOf(build('/profile/12345', fullSearch))
-    expect(p.operatorId).toBeUndefined()
-    expect(p.lineNumber).toBeUndefined()
-    expect(p.date).toBeUndefined()
-    expect(p.routeKey).toBeUndefined()
-    expect(p.rideTime).toBeUndefined()
-  })
-
-  it('page params (rideTime) are included', () => {
-    const p = paramsOf(build('/profile/12345', fullSearch, { rideTime: '08:30:00' }))
-    expect(p.rideTime).toBe('08:30:00')
-  })
-
-  it('profile id is preserved in the pathname', () => {
-    const url = new URL(build('/profile/12345', fullSearch, { rideTime: '08:30:00' }))
-    expect(url.pathname).toBe('/profile/12345')
-  })
-})

src/locale/ar.json

@@ -79,7 +79,6 @@
       "year": "سنوياً"
     },
     "all_lines_on_date": "جميع الخطوط في هذا التاريخ",
-    "profile": "بروفايل",
     "map": "خريطة",
     "id": "معرّف تقني",
     "origin": "المصدر",
@@ -229,6 +228,7 @@
   "from": "المصدر",
   "destination": "الوجهة",
   "kmh": "كم/ساعة",
+  "agency_name": "اسم الشركة المشغّلة",
   "sample_time": "وقت العيّنة",
   "at_time": "في الساعة",
   "drive_direction": "اتّجاه السير",
@@ -309,38 +309,6 @@
     "complaint_details_required": "لكي نتمكّن من فحص طلبك، يُرجى ذكر وسائل النقل المطلوب التنسيق بينها، وأرقام الخطوط، وأسماء المشغّلين، والرقم الكتالوجي للمحطة والأوقات ذات الصلة.",
     "new_complaint": "شكوى جديدة"
   },
-  "lineProfile": {
-    "title": "بروفايل الخط",
-    "notFound": "ما قدرنا نلاقي الخط اللي بتدوّر عليه :(",
-    "id": "معرّف تقني",
-    "date": "التاريخ",
-    "lineReference": "معرّف الخط",
-    "operatorReference": "معرّف الشركة المشغّلة",
-    "agencyName": "اسم الشركة المشغّلة",
-    "route": {
-      "shortName": "رقم الخط",
-      "start": "المصدر",
-      "end": "الوجهة",
-      "mkt": "رمز الخط",
-      "direction": "اتّجاه الخط",
-      "direction_forth": "ذهاب",
-      "direction_back": "إياب",
-      "alternative": "بديل رقم",
-      "type": "نوع الخط"
-    },
-    "ride": {
-      "journey": "معرّف الرحلة",
-      "id": "معرّف تقني",
-      "duration": "مدّة الرحلة"
-    },
-    "stop": {
-      "name": "اسم المحطّة",
-      "code": "رقم المحطّة",
-      "route": "مسار المحطّة",
-      "of": "من أصل",
-      "location": "إحداثيات"
-    }
-  },
   "errorPage": {
     "title": "عفواً، حدث خطأ ما",
     "text": "يُرجى المحاولة مرّة أخرى لاحقاً",

src/locale/en.json

@@ -94,7 +94,6 @@
       "year": "Yearly"
     },
     "all_lines_on_date": "All Lines on This Date",
-    "profile": "Profile",
     "map": "Map",
     "id": "ID",
     "origin": "Origin",
@@ -261,6 +260,7 @@
   "from": "from",
   "destination": "destination",
   "kmh": "kmh",
+  "agency_name": "Agency Name",
   "sample_time": "sample time",
   "at_time": "at",
   "drive_direction": "drive direction",
@@ -341,38 +341,6 @@
     "complaint_details_required": "In order for us to check your request, please specify in the request which modes of transportation you wish to match, line numbers, operator names, station SKU, and relevant times.",
     "new_complaint": "New Complaint"
   },
-  "lineProfile": {
-    "title": "Profile for Line",
-    "notFound": "We couldn't find the line you were looking for :(",
-    "id": "ID",
-    "date": "Date",
-    "lineReference": "Line Reference",
-    "operatorReference": "Operator Reference",
-    "agencyName": "Agency Name",
-    "route": {
-      "shortName": "Route Short Name",
-      "start": "Start",
-      "end": "End",
-      "mkt": "Route MKT",
-      "direction": "Route Direction",
-      "direction_forth": "Forward",
-      "direction_back": "Backward",
-      "alternative": "Route Alternative",
-      "type": "Route Type"
-    },
-    "ride": {
-      "journey": "Journey ID",
-      "id": "Ride ID",
-      "duration": "Ride Duration"
-    },
-    "stop": {
-      "name": "Stop Name",
-      "code": "Stop ID",
-      "route": "Stop Route",
-      "of": "of",
-      "location": "Stop Location"
-    }
-  },
   "errorPage": {
     "title": "Oops, something went wrong",
     "text": "Please try again later",

src/locale/he.json

@@ -94,7 +94,6 @@
       "year": "שנתית"
     },
     "all_lines_on_date": "כל הקווים בתאריך זה",
-    "profile": "פרופיל",
     "map": "מפה",
     "id": "מזהה טכני",
     "origin": "מוצא",
@@ -261,6 +260,7 @@
   "from": "מוצא",
   "destination": "יעד",
   "kmh": "קמ״ש",
+  "agency_name": "שם חברה מפעילה",
   "sample_time": "זמן דגימה",
   "at_time": "בשעה",
   "drive_direction": "כיוון נסיעה",
@@ -341,38 +341,6 @@
     "complaint_details_required": "על מנת שנוכל לבדוק בקשתך, יש לפרט במסגרת הבקשה בין אילו אמצעי תחבורה ברצונך להתאים, מספרי קווים, שמות מפעילים, מק\"ט תחנה ושעות רלוונטיות.",
     "new_complaint": "תלונה חדשה"
   },
-  "lineProfile": {
-    "title": "פרופיל קו",
-    "notFound": "לא הצלחנו למצוא את הקו שחיפשת :(",
-    "id": "מזהה טכני",
-    "date": "תאריך",
-    "lineReference": "מזהה קו",
-    "operatorReference": "מזהה חברה מפעילה",
-    "agencyName": "שם חברה מפעילה",
-    "route": {
-      "shortName": "מס' קו",
-      "start": "מוצא",
-      "end": "יעד",
-      "mkt": "מק\"ט קו",
-      "direction": "כיוון קו",
-      "direction_forth": "הלוך",
-      "direction_back": "חזור",
-      "alternative": "חלופה מס'",
-      "type": "סוג קו"
-    },
-    "ride": {
-      "journey": "מזהה נסיעה",
-      "id": "מזהה טכני",
-      "duration": "זמן נסיעה"
-    },
-    "stop": {
-      "name": "שם תחנה",
-      "code": "מספר תחנה",
-      "route": "מסלול תחנה",
-      "of": "מתוך",
-      "location": "נ\"צ"
-    }
-  },
   "errorPage": {
     "title": "אופס, משהו השתבש",
     "text": "אנא נסה שוב מאוחר יותר",

src/locale/ru.json

@@ -79,7 +79,6 @@
       "year": "Ежегодно"
     },
     "all_lines_on_date": "Все линии на эту дату",
-    "profile": "Профиль",
     "map": "Карта",
     "id": "ID",
     "origin": "Пункт отправления",
@@ -229,6 +228,7 @@
   "from": "от",
   "destination": "пункт назначения",
   "kmh": "км/ч",
+  "agency_name": "Название агентства",
   "sample_time": "время выборки",
   "at_time": "в",
   "drive_direction": "направление движения",
@@ -309,38 +309,6 @@
     "complaint_details_required": "Чтобы мы могли рассмотреть вашу заявку, необходимо подробно описать, между какими видами транспорта вы хотите обеспечить стыковку: укажите номера маршрутов, названия перевозчиков, каталожный номер остановки и соответствующее время.",
     "new_complaint": "Новая жалоба"
   },
-  "lineProfile": {
-    "title": "Профиль для линии",
-    "notFound": "Мы не смогли найти линию, которую вы искали :(",
-    "id": "ID",
-    "date": "Дата",
-    "lineReference": "Ссылка на линию",
-    "operatorReference": "Ссылка на оператора",
-    "agencyName": "Название агентства",
-    "route": {
-      "shortName": "Короткое название маршрута",
-      "start": "Начало",
-      "end": "Конец",
-      "mkt": "Маршрут MKT",
-      "direction": "Направление маршрута",
-      "direction_forth": "Вперед",
-      "direction_back": "Назад",
-      "alternative": "Альтернатива маршрута",
-      "type": "Тип маршрута"
-    },
-    "ride": {
-      "journey": "ID рейса",
-      "id": "ID поездки",
-      "duration": "Продолжительность поездки"
-    },
-    "stop": {
-      "name": "Название остановки",
-      "code": "ID остановки",
-      "route": "Маршрут остановки",
-      "of": "из",
-      "location": "Местоположение остановки"
-    }
-  },
   "errorPage": {
     "title": "Упс, что-то пошло не так",
     "text": "Пожалуйста, попробуйте позже",

src/model/globalState.ts

@@ -21,7 +21,7 @@ export type GlobalSearchState = {
    *  Set by /gaps when the user clicks a row; consumed by /single-line-map. */
   rideTime: string | null
 
-  /** Selected stop key — shared across /station-stops, /single-line-map, /line-profile. */
+  /** Selected stop key — shared across /station-stops, /single-line-map. */
   stopKey: string | null
 }
 

src/pages/components/map-related/MapLayers/BusToolTip.tsx

@@ -1,10 +1,11 @@
 import { GtfsRoutePydanticModel } from '@hasadna/open-bus-api-client'
 import { Button, CircularProgress } from '@mui/material'
-import { ReactNode, useEffect, useState } from 'react'
+import { ReactNode, useContext, useEffect, useState } from 'react'
 import { useTranslation } from 'react-i18next'
-import { Link } from 'react-router'
+import { Link, useNavigate } from 'react-router'
 import { getRoutesByLineRef } from 'src/api/gtfsService'
 import dayjs, { ISRAEL_TIMEZONE } from 'src/dayjs'
+import { GlobalSearchContext } from 'src/model/globalState'
 import { toCivilDate, todayCivilDate } from 'src/model/time/civilDate'
 import { routeStartEnd, vehicleIDFormat } from 'src/pages/components/utils/rotueUtils'
 import SkeletonLoader from 'src/shared/SkeletonLoader'
@@ -14,14 +15,23 @@ import type { Point } from '../map-types'
 import ComplaintModal from './ComplaintModal'
 import './BusToolTip.scss'
 
-export type BusToolTipProps = { position: Point; icon: string; children?: ReactNode }
+export type BusToolTipProps = {
+  position: Point
+  icon: string
+  children?: ReactNode
+  /** Turn the line number into a link to /single-line-map. Off by default: the
+   *  line-specific maps that render this tooltip are already showing that line. */
+  linkToLineMap?: boolean
+}
 
-export function BusToolTip({ position, icon, children }: BusToolTipProps) {
+export function BusToolTip({ position, icon, children, linkToLineMap }: BusToolTipProps) {
   const [route, setRoute] = useState<GtfsRoutePydanticModel>()
   const [isLoading, setIsLoading] = useState(false)
   const [showJson, setShowJson] = useState(false)
   const { t, i18n } = useTranslation()
   const [modalOpen, setModalOpen] = useState(false)
+  const { setSearch } = useContext(GlobalSearchContext)
+  const navigate = useNavigate()
 
   useEffect(() => {
     if (!position.point?.id) return
@@ -69,6 +79,18 @@ export function BusToolTip({ position, icon, children }: BusToolTipProps) {
   }
 
   const [from, destination] = routeStartEnd(route?.routeLongName)
+  const lineLabel = route?.routeShortName || 'NaN' // 'NaN' is the fallback for a missing route number
+
+  const showOnLineMap = (route: GtfsRoutePydanticModel) => {
+    setSearch((current) => ({
+      ...current,
+      date: toCivilDate(route.date) ?? current.date,
+      operatorId: route.operatorRef.toString(),
+      lineNumber: route.routeShortName ?? null,
+      routeKey: `${route.routeMkt}-${route.routeDirection}-${route.routeAlternative}`,
+    }))
+    void navigate('/single-line-map')
+  }
 
   return (
     <div className="bus-tooltip" dir={i18n.dir()}>
@@ -86,8 +108,18 @@ export function BusToolTip({ position, icon, children }: BusToolTipProps) {
             <h1 className="title">
               {`${t('line')}: `}
               <span>
-                {/* eslint-disable-next-line i18next/no-literal-string -- fallback for a missing route number */}
-                <Link to={`/profile/${route.id}`}>{route?.routeShortName || 'NaN'}</Link>
+                {linkToLineMap ? (
+                  <Link
+                    to="/single-line-map"
+                    onClick={(e) => {
+                      e.preventDefault()
+                      showOnLineMap(route)
+                    }}>
+                    {lineLabel}
+                  </Link>
+                ) : (
+                  lineLabel
+                )}
               </span>
             </h1>
             <Link to={`/operator?operatorId=${position.point?.siriRouteOperatorRef}`}>
@@ -97,7 +129,7 @@ export function BusToolTip({ position, icon, children }: BusToolTipProps) {
           <div className="content">
             <ul>
               <li>
-                {`${t('lineProfile.agencyName')}: `}
+                {`${t('agency_name')}: `}
 
                 <span>
                   <Link to={`/operator?operatorId=${position.point?.siriRouteOperatorRef}`}>