feat(service-worker): enhance caching and activation logic (#1329)

Author: AvivAbachi

public/service-worker.js

@@ -1,34 +1,52 @@
-const CACHE_NAME = 'get-requests-cache-v1'
-const CACHE_URLS = []
-
-const urlsToFetch = ['open-bus-stride-api', 'fonts.googleapis.com']
+const CACHE_NAME = 'get-requests-cache-v2'
+const CACHE_URLS = ['open-bus-stride-api', 'fonts.googleapis.com']
 
 // Install event: cache basic URLs (optional)
 self.addEventListener('install', (event) => {
   event.waitUntil(caches.open(CACHE_NAME).then((cache) => cache.addAll(CACHE_URLS)))
+  self.skipWaiting()
+})
+
+// Activate event: clear old caches
+self.addEventListener('activate', (event) => {
+  event.waitUntil(
+    caches.keys().then((cacheNames) =>
+      Promise.all(
+        cacheNames.map((cacheName) => {
+          if (cacheName !== CACHE_NAME) {
+            return caches.delete(cacheName)
+          }
+        }),
+      ),
+    ),
+  )
+  self.clients.claim()
 })
 
-// Fetch event: cache GET requests
+// Fetch event: cache GET requests except when query includes today's date
 self.addEventListener('fetch', (event) => {
+  const today = new Date().toISOString().slice(0, 10) // e.g. "2025-10-28"
+
   if (
     event.request.method === 'GET' &&
-    urlsToFetch.some((url) => event.request.url.includes(url))
+    !event.request.url.includes(today) &&
+    CACHE_URLS.some((url) => event.request.url.includes(url))
   ) {
     event.respondWith(
       caches.match(event.request).then((cachedResponse) => {
-        // Return cached response if available, else fetch from network
-        return (
-          cachedResponse ||
-          fetch(event.request).then((response) => {
-            // Clone the response to save it in the cache
+        // Return cached response if available
+        if (cachedResponse) return cachedResponse
+
+        // Otherwise, fetch from network and cache the response
+        return fetch(event.request).then((response) => {
+          if (response.ok) {
             const responseClone = response.clone()
             caches.open(CACHE_NAME).then((cache) => {
               cache.put(event.request, responseClone)
             })
-            console.log('cached ', event.request)
-            return response
-          })
-        )
+          }
+          return response
+        })
       }),
     )
   }

tests/HAR/clearbutton.har

@@ -3,30 +3,28 @@
     "version": "1.2",
     "creator": {
       "name": "Playwright",
-      "version": "1.56.1"
+      "version": "1.55.0"
     },
     "browser": {
       "name": "chromium",
-      "version": "141.0.7390.37"
+      "version": "140.0.7339.16"
     },
     "entries": [
       {
-        "startedDateTime": "2025-10-30T15:51:00.240Z",
-        "time": 3.674,
+        "startedDateTime": "2025-11-10T18:10:27.893Z",
+        "time": 16.209,
         "request": {
           "method": "GET",
           "url": "https://open-bus-stride-api.hasadna.org.il/gtfs_agencies/list?date_from=2024-02-11",
           "httpVersion": "HTTP/2.0",
           "cookies": [],
           "headers": [
-            { "name": "Accept", "value": "*/*" },
-            { "name": "Accept-Language", "value": "en-US" },
-            { "name": "Origin", "value": "http://localhost:3000" },
+            { "name": "sec-ch-ua-platform", "value": "\"Windows\"" },
             { "name": "Referer", "value": "http://localhost:3000/" },
-            { "name": "User-Agent", "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/141.0.7390.37 Safari/537.36" },
-            { "name": "sec-ch-ua", "value": "\"HeadlessChrome\";v=\"141\", \"Not?A_Brand\";v=\"8\", \"Chromium\";v=\"141\"" },
-            { "name": "sec-ch-ua-mobile", "value": "?0" },
-            { "name": "sec-ch-ua-platform", "value": "\"Windows\"" }
+            { "name": "User-Agent", "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.7339.16 Safari/537.36" },
+            { "name": "sec-ch-ua", "value": "\"Chromium\";v=\"140\", \"Not=A?Brand\";v=\"24\", \"HeadlessChrome\";v=\"140\"" },
+            { "name": "Accept-Language", "value": "en-US" },
+            { "name": "sec-ch-ua-mobile", "value": "?0" }
           ],
           "queryString": [
             {
@@ -43,11 +41,11 @@
           "httpVersion": "HTTP/2.0",
           "cookies": [],
           "headers": [
+            { "name": "strict-transport-security", "value": "max-age=31536000; includeSubDomains" },
             { "name": "access-control-allow-origin", "value": "*" },
             { "name": "content-length", "value": "8145" },
-            { "name": "content-type", "value": "application/json" },
-            { "name": "date", "value": "Thu, 30 Oct 2025 15:51:00 GMT" },
-            { "name": "strict-transport-security", "value": "max-age=31536000; includeSubDomains" }
+            { "name": "date", "value": "Mon, 10 Nov 2025 18:10:27 GMT" },
+            { "name": "content-type", "value": "application/json" }
           ],
           "content": {
             "size": -1,
@@ -59,7 +57,7 @@
           "redirectURL": ""
         },
         "cache": {},
-        "timings": { "send": -1, "wait": -1, "receive": 3.674 }
+        "timings": { "send": -1, "wait": -1, "receive": 16.209 }
       }
     ]
   }