Added authorship pallet migration to the RuntimeUpgrades struct. Developed the system pallet migration to verify the correct decoding of the block weight and digest storage items. Developed the authorship pallet migration. Developed the society pallet verifier migration. Developed the xcmp queue pallet verifier migration.

Author: sebastianmontero

runtime/src/lib.rs

@@ -143,13 +143,16 @@ pub type RuntimeUpgrades = (
 	migrations::transaction_payment::v0::Migrate,
 	migrations::uniques::v0::MigrateToV1,
 	migrations::vesting::v0::MigrateToV1,
+	migrations::authorship::v0::Migrate,
 	migrations::general::GeneralMigration,
 	migrations::identity_verifier::Migrate,
 	migrations::aura_verifier::Migrate,
 	migrations::balances_verifier::Migrate,
 	migrations::collator_selection_verifier::Migrate,
 	migrations::dmp_queue_verifier::Migrate,
-	migrations::proxy_verifier::Migrate
+	migrations::proxy_verifier::Migrate,
+	migrations::society_verifier::Migrate,
+	migrations::xcmp_queue_verifier::Migrate
 );
 
 /// Executive: handles dispatch to the various modules.

runtime/src/migrations/authorship.rs

@@ -0,0 +1,35 @@
+use super::*;
+use crate::*;
+use frame_support::{
+	pallet_prelude::*,
+	traits::{Currency, OnRuntimeUpgrade},
+};
+
+#[cfg(feature = "try-runtime")]
+use sp_runtime::TryRuntimeError;
+
+/// The log target.
+const TARGET: &'static str = "runtime::authorship::migration";
+
+pub mod v0 {
+	use super::*;
+	/// The actual type isn't important, as we only delete the key in the state.
+	#[frame_support::storage_alias]
+	pub(super) type Uncles<T: pallet_authorship::Config> =
+		StorageValue<pallet_authorship::Pallet<T>, (), ValueQuery>;
+
+	#[frame_support::storage_alias]
+	pub(super) type DidSetUncles<T: pallet_authorship::Config> =
+		StorageValue<pallet_authorship::Pallet<T>, bool, ValueQuery>;
+
+	pub struct Migrate;
+
+	impl OnRuntimeUpgrade for Migrate {
+		fn on_runtime_upgrade() -> Weight {
+			Uncles::<Runtime>::kill();
+			DidSetUncles::<Runtime>::kill();
+			log::info!(target: TARGET, "Killed deprecated storages");
+			<Runtime as frame_system::Config>::DbWeight::get().reads_writes(0, 2)
+		}
+	}
+}

runtime/src/migrations/mod.rs

@@ -10,3 +10,6 @@ pub mod vesting;
 pub mod collator_selection_verifier;
 pub mod dmp_queue_verifier;
 pub mod proxy_verifier;
+pub mod society_verifier;
+pub mod xcmp_queue_verifier;
+pub mod authorship;

runtime/src/migrations/society_verifier.rs

@@ -0,0 +1,40 @@
+use crate::*;
+use frame_support::{
+	pallet_prelude::*,
+	traits::{Currency, OnRuntimeUpgrade},
+};
+use frame_system::pallet_prelude::BlockNumberFor;
+use super::*;
+
+#[cfg(feature = "try-runtime")]
+use sp_runtime::TryRuntimeError;
+
+/// The log target.
+const TARGET: &'static str = "runtime::society_verifier::migration";
+
+pub struct Migrate;
+
+impl OnRuntimeUpgrade for Migrate {
+
+	fn on_runtime_upgrade() -> Weight {
+		return Weight::zero()
+	}
+
+	#[cfg(feature = "try-runtime")]
+	fn post_upgrade(state: Vec<u8>) -> Result<(), TryRuntimeError> {
+		log::info!(target: TARGET, "In post upgrade");
+
+		let candidates_count = pallet_society::Candidates::<Runtime>::iter_keys().count() as u32;
+		let decodable_candidates_count = pallet_society::Candidates::<Runtime>::iter_values().count() as u32;
+		// IdentityOf::<Runtime>::get(key)
+		pallet_society::Candidates::<Runtime>::iter().for_each(|(k, v)| {
+			let account_bytes: [u8; 32] = k.clone().into();
+			log::info!("    ");
+			log::info!("    ");
+			log::info!("key account bytes: {:?} ", account_bytes);
+			log::info!("Candidacy: {:?}", v);
+		});
+		log::info!(target: TARGET, "Num candidates: {}, decodable: {}", candidates_count, decodable_candidates_count);
+		Ok(())
+	}
+}

runtime/src/migrations/system.rs

@@ -6,6 +6,7 @@ use frame_support::{
 	traits::{Currency, OnRuntimeUpgrade},
 };
 use frame_system::pallet_prelude::BlockNumberFor;
+use frame_system::ConsumedWeight;
 #[cfg(feature = "try-runtime")]
 use sp_runtime::TryRuntimeError;
 
@@ -35,6 +36,12 @@ pub mod v0 {
 	pub(super) type Events<T: frame_system::Config> =
 		StorageValue<frame_system::Pallet<T>, Vec<Box<EventRecord<<T as frame_system::Config>::RuntimeEvent, <T as frame_system::Config>::Hash>>>, ValueQuery>;
 
+	#[frame_support::storage_alias]
+	pub(super) type BlockWeight<T: frame_system::Config> = StorageValue<frame_system::Pallet<T>, ConsumedWeight, ValueQuery>;
+
+	#[frame_support::storage_alias]
+	pub(super) type Digest<T: frame_system::Config> = StorageValue<frame_system::Pallet<T>, generic::Digest, ValueQuery>;
+
 	pub struct Migrate;
 
 	impl OnRuntimeUpgrade for Migrate {
@@ -104,6 +111,9 @@ pub mod v0 {
 				log::info!("Sufficients: {:?}", v.sufficients);
 				log::info!("Data: {:?}", v.data);
 			});
+			log::info!(target: TARGET, "block weight: {:?}", BlockWeight::<Runtime>::get());
+			log::info!(target: TARGET, "digest: {:?}", Digest::<Runtime>::get());
+			log::info!(target: TARGET, "last runtime upgrade: {:?}", frame_system::LastRuntimeUpgrade::<Runtime>::get());
 			// let events = Events::<Runtime>::get();
 			// log::info!(target: TARGET, "num_events: {}", events.len());
 			// events.iter().take(10).for_each(|v|{

runtime/src/migrations/transaction_payment.rs

@@ -55,7 +55,6 @@ use sp_runtime::traits::Saturating;
 		}
 		//We are just updating the storage version, as the pallet is already on the latest version
 		fn on_runtime_upgrade() -> Weight {
-			let storage_version = StorageVersion::<Runtime>::get();
 			let mut writes = 0;
 			let storage_version = StorageVersion::<Runtime>::get();
 			if storage_version == Releases::V1Ancient {

runtime/src/migrations/xcmp_queue_verifier.rs

@@ -0,0 +1,51 @@
+use crate::*;
+use frame_support::{
+	pallet_prelude::*,
+	traits::{Currency, OnRuntimeUpgrade},
+};
+use frame_system::pallet_prelude::BlockNumberFor;
+use cumulus_pallet_xcmp_queue::{QueueConfigData, OverweightIndex};
+use cumulus_primitives_core::relay_chain::BlockNumber as RelayBlockNumber;
+use crate::ParaId;
+use super::*;
+
+#[cfg(feature = "try-runtime")]
+use sp_runtime::TryRuntimeError;
+
+/// The log target.
+const TARGET: &'static str = "runtime::xcmp_queue_verifier::migration";
+
+
+#[frame_support::storage_alias]
+pub(super) type Overweight<T: cumulus_pallet_xcmp_queue::Config> =
+		CountedStorageMap<cumulus_pallet_xcmp_queue::Pallet<T>, Twox64Concat, OverweightIndex, (ParaId, RelayBlockNumber, Vec<u8>)>;
+
+#[frame_support::storage_alias]
+pub(super) type QueueConfig<T: cumulus_pallet_xcmp_queue::Config> = StorageValue<cumulus_pallet_xcmp_queue::Pallet<T>, QueueConfigData, ValueQuery>;
+
+pub struct Migrate;
+
+impl OnRuntimeUpgrade for Migrate {
+
+	fn on_runtime_upgrade() -> Weight {
+		return Weight::zero()
+	}
+
+	#[cfg(feature = "try-runtime")]
+	fn post_upgrade(state: Vec<u8>) -> Result<(), TryRuntimeError> {
+		log::info!(target: TARGET, "In post upgrade");
+		let overweight_tracked_count = Overweight::<Runtime>::count();
+		let overweight_count = Overweight::<Runtime>::iter_keys().count() as u32;
+		let decodable_overweight_count = Overweight::<Runtime>::iter_values().count() as u32;
+		log::info!(target: TARGET, "Num overweight: {}, decodable: {}, tracked: {}", overweight_count, decodable_overweight_count, overweight_tracked_count);
+		Overweight::<Runtime>::iter().for_each(|(k, v)| {
+			log::info!("    ");
+			log::info!("    ");
+			log::info!("overweight index: {} ", k);
+			log::info!("overweight: {:?}", v);
+		});
+
+		log::info!("config data: {:?} ", QueueConfig::<Runtime>::get());
+		Ok(())
+	}
+}