fix: add optional field

Signed-off-by: Axel Loupias <[email protected]>

Author: Axel-IoBuilders

packages/ats/sdk/__tests__/fixtures/beneficiary/BeneficiaryFixture.ts

@@ -45,7 +45,7 @@ export const AddBeneficiaryCommandFixture =
   createFixture<AddBeneficiaryCommand>((command) => {
     command.securityId.as(() => HederaIdPropsFixture.create().value);
     command.beneficiary.as(() => HederaIdPropsFixture.create().value);
-    command.data.as(() => '0x');
+    command.data?.as(() => '0x');
   });
 
 export const RemoveBeneficiaryCommandFixture =

packages/ats/sdk/__tests__/fixtures/bond/BondFixture.ts

@@ -258,7 +258,6 @@ import {
 import AddBeneficiaryRequest from '@port/in/request/bond/AddBeneficiaryRequest';
 import RemoveBeneficiaryRequest from '@port/in/request/bond/RemoveBeneficiaryRequest';
 import UpdateBeneficiaryDataRequest from '@port/in/request/bond/UpdateBeneficiaryDataRequest';
-import GetBeneficiariesDataRequest from '@port/in/request/bond/GetBeneficiaryDataRequest';
 
 export const SetCouponCommandFixture = createFixture<SetCouponCommand>(
   (command) => {
@@ -783,7 +782,7 @@ export const AddBeneficiaryRequestFixture =
   createFixture<AddBeneficiaryRequest>((request) => {
     request.securityId.as(() => HederaIdPropsFixture.create().value);
     request.beneficiaryId.as(() => HederaIdPropsFixture.create().value);
-    request.data.as(() => '0x');
+    request.data?.as(() => '0x');
   });
 export const UpdateBeneficiaryDataRequestFixture =
   createFixture<UpdateBeneficiaryDataRequest>((request) => {

packages/ats/sdk/src/app/usecase/command/security/beneficiaries/addBeneficiary/AddBeneficiaryCommand.ts

@@ -184,7 +184,7 @@ export class AddBeneficiaryCommand extends Command<AddBeneficiaryCommandResponse
   constructor(
     public readonly securityId: string,
     public readonly beneficiary: string,
-    public readonly data: string,
+    public readonly data?: string,
   ) {
     super();
   }

packages/ats/sdk/src/app/usecase/command/security/beneficiaries/addBeneficiary/AddBeneficiaryCommandHandler.ts

@@ -212,7 +212,7 @@ export class AddBeneficiaryCommandHandler
         await this.contractService.getContractEvmAddress(securityId);
 
       const beneficiaryEvmAddress: EvmAddress =
-        await this.contractService.getContractEvmAddress(beneficiary);
+        await this.accountService.getAccountEvmAddress(beneficiary);
 
       await this.validationService.checkPause(securityId);
 

packages/ats/sdk/src/port/in/request/bond/AddBeneficiaryRequest.ts

@@ -205,11 +205,13 @@
 
 import ValidatedRequest from '@core/validation/ValidatedArgs';
 import FormatValidation from '../FormatValidation';
+import { OptionalField } from '@core/decorator/OptionalDecorator';
 
 export default class AddBeneficiaryRequest extends ValidatedRequest<AddBeneficiaryRequest> {
   securityId: string;
   beneficiaryId: string;
-  data: string;
+  @OptionalField()
+  data?: string;
 
   constructor({
     securityId,
@@ -218,7 +220,7 @@ export default class AddBeneficiaryRequest extends ValidatedRequest<AddBeneficia
   }: {
     securityId: string;
     beneficiaryId: string;
-    data: string;
+    data?: string;
   }) {
     super({
       beneficiaryId: FormatValidation.checkHederaIdFormatOrEvmAddress(),

packages/ats/sdk/src/port/out/TransactionAdapter.ts

@@ -1925,7 +1925,7 @@ export default abstract class TransactionAdapter
   abstract addBeneficiary(
     security: EvmAddress,
     beneficiary: EvmAddress,
-    data: string,
+    data?: string,
     securityId?: ContractId | string,
   ): Promise<TransactionResponse>;
   abstract removeBeneficiary(

packages/ats/sdk/src/port/out/rpc/RPCTransactionAdapter.ts

@@ -3374,7 +3374,7 @@ export class RPCTransactionAdapter extends TransactionAdapter {
   addBeneficiary(
     security: EvmAddress,
     beneficiary: EvmAddress,
-    data: string,
+    data?: string,
     securityId?: ContractId | string,
   ): Promise<TransactionResponse> {
     LogService.logTrace(
@@ -3386,7 +3386,7 @@ export class RPCTransactionAdapter extends TransactionAdapter {
         this.getSignerOrProvider(),
       ),
       'addBeneficiary',
-      [beneficiary.toString(), data],
+      [beneficiary.toString(), data ?? '0x'],
       GAS.ADD_BENEFICIARY,
     );
   }