fix: remove duplicated fragments warning

Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>

Author: MiguelLZPF

.changeset/test-performance-optimization.md

@@ -0,0 +1,6 @@
+---
+"@hashgraph/asset-tokenization-contracts": patch
+---
+
+- Optimize test fixture deployment speed (96% improvement). Improved contract test performance from 47 seconds to 2 seconds per fixture by fixing inefficient batch processing and removing unnecessary network delays on instant-mining networks (Hardhat/local).
+- Remove duplicated contract interface fragments in test files (ERC3643, clearing, protectedPartitions tests).

package.json

@@ -36,7 +36,8 @@
     "clean:full": "npm run clean:workspaces && npm run clean:deps:full && npm run clean:root && echo '\\n✅ Complete cleanup finished — workspaces, dependencies, and root junk removed'",
     "lint:staged:js": "eslint --cache",
     "lint:staged:sol": "solhint --config packages/ats/contracts/.solhint.json",
-    "format:staged": "prettier --check",
+    "format:staged": "prettier --write",
+    "format:staged:check": "prettier --check",
     "pre-commit": "lint-staged",
     "commitlint": "commitlint --edit",
     "prepare": "husky",

packages/ats/contracts/test/contracts/unit/layer_1/ERC3643/erc3643.test.ts

@@ -199,16 +199,21 @@ describe("ERC3643 Tests", () => {
       );
       const clearingTransferFacet = await ethers.getContractAt("ClearingTransferFacet", diamond.address, signer_A);
 
-      clearingFacet = new Contract(
-        diamond.address,
-        [
-          ...clearingTransferFacet.interface.fragments,
-          ...clearingRedeemFacet.interface.fragments,
-          ...clearingHoldCreationFacet.interface.fragments,
-          ...clearingActionsFacet.interface.fragments,
-        ],
-        signer_A,
-      );
+      const fragmentMap = new Map<string, any>();
+      [
+        ...clearingTransferFacet.interface.fragments,
+        ...clearingRedeemFacet.interface.fragments,
+        ...clearingHoldCreationFacet.interface.fragments,
+        ...clearingActionsFacet.interface.fragments,
+      ].forEach((fragment) => {
+        const key = fragment.format();
+        if (!fragmentMap.has(key)) {
+          fragmentMap.set(key, fragment);
+        }
+      });
+
+      const uniqueFragments = Array.from(fragmentMap.values());
+      clearingFacet = new Contract(diamond.address, uniqueFragments, signer_A);
       holdFacet = await ethers.getContractAt("IHold", diamond.address, signer_A);
       protectedPartitionsFacet = await ethers.getContractAt("ProtectedPartitions", diamond.address);
       diamondFacet = await ethers.getContractAt("DiamondFacet", diamond.address);

packages/ats/contracts/test/contracts/unit/layer_1/clearing/clearing.test.ts

@@ -7,6 +7,7 @@ import { loadFixture } from "@nomicfoundation/hardhat-network-helpers";
 import {
   type ResolverProxy,
   type ClearingActionsFacet,
+  ClearingActionsFacet__factory,
   type IHold,
   ControlList,
   Pause,
@@ -126,21 +127,27 @@ describe("Clearing Tests", () => {
       signer_A,
     );
     const clearingReadFacet = await ethers.getContractAt("ClearingReadFacet", diamond.address, signer_A);
+    clearingActionsFacet = ClearingActionsFacet__factory.connect(diamond.address, signer_A);
+
+    const fragmentMap = new Map<string, any>();
+    [
+      ...clearingTransferFacet.interface.fragments,
+      ...clearingRedeemFacet.interface.fragments,
+      ...clearingHoldCreationFacet.interface.fragments,
+      ...clearingReadFacet.interface.fragments,
+      ...clearingActionsFacet.interface.fragments,
+    ].forEach((fragment) => {
+      const key = fragment.format();
+      if (!fragmentMap.has(key)) {
+        fragmentMap.set(key, fragment);
+      }
+    });
 
-    // TODO : refactor one facet with all the interfaces
-    clearingFacet = new Contract(
-      diamond.address,
-      [
-        ...clearingTransferFacet.interface.fragments,
-        ...clearingRedeemFacet.interface.fragments,
-        ...clearingHoldCreationFacet.interface.fragments,
-        ...clearingReadFacet.interface.fragments,
-      ],
-      signer_A,
-    );
+    const uniqueFragments = Array.from(fragmentMap.values());
+
+    clearingFacet = new Contract(diamond.address, uniqueFragments, signer_A);
 
     holdFacet = await ethers.getContractAt("IHold", diamond.address, signer_A);
-    clearingActionsFacet = await ethers.getContractAt("ClearingActionsFacet", diamond.address, signer_A);
     equityFacet = await ethers.getContractAt("Equity", diamond.address, signer_A);
     accessControlFacet = await ethers.getContractAt("AccessControlFacet", diamond.address, signer_A);
     adjustBalancesFacet = await ethers.getContractAt("AdjustBalances", diamond.address, signer_A);

packages/ats/contracts/test/contracts/unit/layer_1/protectedPartitions/protectedPartitions.test.ts

@@ -267,17 +267,23 @@ describe("ProtectedPartitions Tests", () => {
     const clearingReadFacet = await ethers.getContractAt("ClearingReadFacet", address, signer_A);
     const clearingActionsFacet = await ethers.getContractAt("ClearingActionsFacet", address, signer_A);
 
-    clearingFacet = new Contract(
-      address,
-      [
-        ...clearingTransferFacet.interface.fragments,
-        ...clearingRedeemFacet.interface.fragments,
-        ...clearingHoldCreationFacet.interface.fragments,
-        ...clearingReadFacet.interface.fragments,
-        ...clearingActionsFacet.interface.fragments,
-      ],
-      signer_A,
-    );
+    const fragmentMap = new Map<string, any>();
+    [
+      ...clearingTransferFacet.interface.fragments,
+      ...clearingRedeemFacet.interface.fragments,
+      ...clearingHoldCreationFacet.interface.fragments,
+      ...clearingReadFacet.interface.fragments,
+      ...clearingActionsFacet.interface.fragments,
+    ].forEach((fragment) => {
+      const key = fragment.format();
+      if (!fragmentMap.has(key)) {
+        fragmentMap.set(key, fragment);
+      }
+    });
+
+    const uniqueFragments = Array.from(fragmentMap.values());
+
+    clearingFacet = new Contract(address, uniqueFragments, signer_A);
 
     if (compliance) {
       complianceMock = await ethers.getContractAt("ComplianceMock", compliance);