Skip to content

Commit e5211b3

Browse files
committed
refactor: standardize variable bracing syntax in release workflows
Improve code consistency by using ${VAR} syntax instead of $VAR for all variable references in release workflows. Changes: - Use ${TAG_NAME} for git tag and push commands in both ATS and MP workflows - Use ${MP_PACKAGES_TO_BUMP} in Mass Payout validation message This addresses PR feedback for improved consistency and follows bash best practices for variable expansion. Addresses: PR #645 comments #3 and #5 from andrewb1269hg Signed-off-by: Miguel_LZPF <[email protected]>
1 parent 7b01283 commit e5211b3

File tree

3 files changed

+1096
-954
lines changed

3 files changed

+1096
-954
lines changed

.github/workflows/ats.release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ jobs:
134134
echo "📦 Creating ATS release: $TAG_NAME"
135135
136136
# Create and push tag
137-
git tag "$TAG_NAME"
138-
git push origin "$TAG_NAME"
137+
git tag "${TAG_NAME}"
138+
git push origin "${TAG_NAME}"
139139
140140
# Generate release notes from ATS package changelogs
141141
RELEASE_NOTES=""

.github/workflows/mp.release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
exit 1
7474
fi
7575
76-
echo "✅ Found $MP_PACKAGES_TO_BUMP Mass Payout package(s) ready for release"
76+
echo "✅ Found ${MP_PACKAGES_TO_BUMP} Mass Payout package(s) ready for release"
7777
7878
# Show which packages will be bumped
7979
echo "📦 Mass Payout packages to be released:"
@@ -134,8 +134,8 @@ jobs:
134134
echo "📦 Creating Mass Payout release: $TAG_NAME"
135135
136136
# Create and push tag
137-
git tag "$TAG_NAME"
138-
git push origin "$TAG_NAME"
137+
git tag "${TAG_NAME}"
138+
git push origin "${TAG_NAME}"
139139
140140
# Generate release notes from Mass Payout package changelogs
141141
RELEASE_NOTES=""

0 commit comments

Comments
 (0)