fix: NodeUpdate and NodeDelete views now disable creation when node id is invalid (#2437)

* NodeUpdate now disable creation when node is invalid.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

* NodeDelete now disables creation when node is invalid.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

---------

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Author: ericleponner

front-end/src/renderer/components/Transaction/Create/NodeDelete/NodeDelete.vue

@@ -36,6 +36,10 @@ const createTransaction = computed<CreateTransactionFunc>(() => {
     });
 });
 
+const createDisabled = computed(() => {
+  return !nodeData.nodeInfo?.value;
+});
+
 /* Handlers */
 const handleDraftLoaded = (transaction: Transaction) => {
   if (transaction instanceof NodeDeleteTransaction) {
@@ -55,18 +59,12 @@ const handleExecutedSuccess = async () => {
   toast.success(`Node ${data.nodeId} Deleted`, successToastOptions);
 };
 
-/* Functions */
-const preCreateAssert = () => {
-  if (!data.nodeId) {
-    throw new Error('Node ID Required');
-  }
-};
 </script>
 <template>
   <BaseTransaction
     ref="baseTransactionRef"
     :create-transaction="createTransaction"
-    :pre-create-assert="preCreateAssert"
+    :create-disabled="createDisabled"
     @executed:success="handleExecutedSuccess"
     @draft-loaded="handleDraftLoaded"
   >

front-end/src/renderer/components/Transaction/Create/NodeUpdate/NodeUpdate.vue

@@ -52,6 +52,10 @@ const createTransaction = computed<CreateTransactionFunc>(() => {
     );
 });
 
+const createDisabled = computed(() => {
+  return !nodeData.nodeInfo?.value;
+});
+
 /* Handlers */
 const handleDraftLoaded = (transaction: Transaction) => {
   if (transaction instanceof NodeUpdateTransaction) {
@@ -75,13 +79,6 @@ const handleExecutedSuccess = async () => {
   toast.success(`Node ${data.nodeAccountId} Updated`, successToastOptions);
 };
 
-/* Functions */
-const preCreateAssert = () => {
-  if (!data.nodeId) {
-    throw new Error('Node ID Required');
-  }
-};
-
 /* Watchers */
 watch(nodeData.nodeInfo, nodeInfo => {
   if (!nodeInfo) {
@@ -119,7 +116,7 @@ watch(
   <BaseTransaction
     ref="baseTransactionRef"
     :create-transaction="createTransaction"
-    :pre-create-assert="preCreateAssert"
+    :create-disabled="createDisabled"
     @executed:success="handleExecutedSuccess"
     @draft-loaded="handleDraftLoaded"
   >