Backport of upgrade: go to v1.25 into release/1.21.x (#22659)

* fix: golangci-lint staticcheck errors (#22642)

* fix: golangci-lint staticcheck errors

* fix: missing braces for else in mesh_gateway.go

* fix: remove unnecessary type check in otel_sink_test.go

* fix: golangci-lint issues (#22644)

* upgrade: golangci-lint to v2 (#22648)

* fix: golangci-lint issues

* migrate golangci-lint config to v2

* upgrade: golangci-lint to v2.4.0

* fix: linter issues in agent/consul (#22651)

* Fixing bind addr issue, ipv6 bracket, valid peering token issue m go-discover update (#22584)

* Fixing bind addr issue, ipv6 bracket and valid peering token issue

* Making addr and port compatible with ipv6

* Updating go-discover to v1.1.0

* Updating testcases

* chore:added workflow to delete stale branches (#22658)

* upgrade: go to v1.25 (#22652)

* update: go version to 1.25

* update: gotestsum version

* update: mog, buf and deep-copy

* fix: add workaround to install covdata in go toolchain

* update: regen proto files

* fix: install deep-copy with go 1.23

* add: changelog

* update: regen deepcopy files

* fix: non-constant format string in formatter

* upgrade: mockery and proto-gen, and regen files (#22634)

* update: mockery to v3 and generate mocks

* update: protoc-gen to v1.5.1 and regen proto go files

* fix: use InterfaceName_mock.go for filename in mockery

* update: generate mock files with mockery v3

* fix: case in structname in mockery config

* update: testcase errMsg in TestPatchStruct

* update: increase timeout for context in TestSubscribeBackend_IntegrationWithServer_TLSReload

---------

Co-authored-by: Sreeram Narayanan <sreeram.narayanan@hashicorp.com>
Co-authored-by: P Ajay Rao <pajay.rao@hashicorp.com>
Co-authored-by: Vikramarjuna <vkrmrjun@gmail.com>

Author: 4 people

.changelog/22652.txt

@@ -0,0 +1,3 @@
+```release-note:security
+security: upgrade go version to 1.25.0
+```

.github/workflows/nightly-test-integ-peering_commontopo.yml

@@ -13,7 +13,7 @@ env:
   TEST_RESULTS_DIR: /tmp/test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.10.1"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations-1.15.x.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations-1.18.x.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations-1.19.x.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations-1.20.x.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations-1.21.x.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/nightly-test-integrations.yml

@@ -14,7 +14,7 @@ env:
   TEST_RESULTS_ARTIFACT_NAME: test-results
   CONSUL_LICENSE: ${{ secrets.CONSUL_LICENSE }}
   GOTAGS: ${{ endsWith(github.repository, '-enterprise') && 'consulent' || '' }}
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   CONSUL_BINARY_UPLOAD_NAME: consul-bin
   # strip the hashicorp/ off the front of github.repository for consul
   CONSUL_LATEST_IMAGE_NAME: ${{ endsWith(github.repository, '-enterprise') && github.repository || 'hashicorp/consul' }}

.github/workflows/reusable-lint.yml

@@ -54,7 +54,7 @@ jobs:
       - name: Set golangci-lint version
         run: echo "GOLANGCI_LINT_VERSION=$(make --no-print-directory print-GOLANGCI_LINT_VERSION)" >> $GITHUB_ENV
       - name: lint-${{ matrix.directory }}
-        uses: golangci/golangci-lint-action@82d40c283aeb1f2b6595839195e95c2d6a49081b # v5.0.0
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
         with:
           working-directory: ${{ matrix.directory }}
           version: ${{ env.GOLANGCI_LINT_VERSION }}

.github/workflows/reusable-unit-split.yml

@@ -49,7 +49,7 @@ on:
         required: true
 env:
   TEST_RESULTS: /tmp/test-results
-  GOTESTSUM_VERSION: "1.11.0"
+  GOTESTSUM_VERSION: "1.12.3"
   GOARCH: ${{inputs.go-arch}}
   TOTAL_RUNNERS: ${{inputs.runner-count}}
   CONSUL_LICENSE: ${{secrets.consul-license}}