feat(ui): `yarn` -> `pnpm`#22790

Merged

suresh-hashicorp merged 17 commits intomainfrom

Sep 26, 2025

Collaborator

aklkv commented Sep 19, 2025 •

edited by suresh-hashicorp

Loading

Description

Replaces yarn with pnpm for managing UI dependencies.

aklkv self-assigned this

github-actions bot added the theme/ui label

Collaborator Author

aklkv commented Sep 22, 2025

Do not add copyright header to auto generated files like package lock file, it should be ignored in copyright header config

suresh-hashicorp added pr/no-changelog backport/all labels

suresh-hashicorp force-pushed the feat/pnpm branch from 21ffd1c to 25bf396 Compare

September 22, 2025 14:03

suresh-hashicorp marked this pull request as ready for review

September 23, 2025 04:56

suresh-hashicorp requested review from a team as code owners

September 23, 2025 04:56

suresh-hashicorp requested a review from jeanneryan

September 23, 2025 04:56

aklkv commented

View reviewed changes

ui/packages/consul-ui/GNUmakefile

               build-staging: deps
-              	yarn run build:staging
+              	pnpm run build:staging

Collaborator Author

aklkv Sep 23, 2025

you do not really need run it's optional

Contributor

suresh-hashicorp Sep 25, 2025

I'll keep run for a little clarity. I would probably get confused if i don't see run. 😄

aklkv commented

View reviewed changes

ui/package.json Outdated

+                  "compliance:licenses": "license-checker --summary --onlyAllow 'Python-2.0;Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;Public Domain;Unicode-TOU;Unlicense;WTFPL' --excludePackages 'consul-ui@2.2.0;consul-acls@0.1.0;consul-lock-sessions@0.1.0;consul-partitions@0.1.0;consul-nspaces@0.1.0;consul-peerings@0.1.0'",
+                  "doc:toc": "doctoc README.md",
+                  "preinstall": "npx only-allow pnpm"

Collaborator Author

aklkv Sep 23, 2025

ops, we need to remove this script, it was a part of migration step, no longer needed

Contributor

suresh-hashicorp commented Sep 23, 2025 •

edited

Loading

Change documentation to refer to pnpm
Update nightly tests workflow to use pnpm
update frontend workflow to use pnpm

Collaborator Author

aklkv commented Sep 23, 2025

you still need node setup and pnpm

suresh-hashicorp force-pushed the feat/pnpm branch from e1e0fbd to ea81567 Compare

September 25, 2025 07:06

aklkv commented

View reviewed changes

.github/workflows/build.yml Outdated

-                        node-version: '20'
-                        cache: 'yarn'
-                        cache-dependency-path: 'ui/yarn.lock'
+                        node-version-file: './ui/.nvmrc'

Collaborator Author

aklkv Sep 25, 2025

if everyone is using nvm this is ok but it might be better to use package.json, i will leave it up to you to decide

Contributor

suresh-hashicorp Sep 25, 2025

I'll change it. It's better if configurations are not scattered.

aklkv and others added 14 commits

September 25, 2025 14:26


          feat(ui): yarn -> pnpm

42f0081


          ui: replace yarn ci commands with pnpm

1386d30


          supress lint errors

a130236


          add copywrite header

b150e46


          remove copywrite header; add ember-template-lint

213bb3e


          ignore pnpm lock file and both the node_modules folders for copyright…

76819d1

… header check


          remove unused commands


          ci: replace node action-setup with pnpm

d8f0cd1


          replace yarn references in docs with pnpm

ca1f5a0


          update nightly tests with pnpm

b82c8e1


          update frontend workflow to use pnpm

ec6abb2


          re introduce setup-node; remove cache as setup-node provides one;


          install pnpm before node for it's cache to work

20b69dc


          use package.json for node versioning; add setup node in frontend work…

08834cd

…flow;

Collaborator

hc-github-team-consul-core commented Feb 27, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

29 similar comments

Collaborator

hc-github-team-consul-core commented Feb 28, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 1, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 2, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 3, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 5, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 6, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 7, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 8, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 9, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 10, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 11, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 12, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 13, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 14, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 15, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 16, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 17, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 18, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 19, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 20, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 21, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 23, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 26, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 27, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 28, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 29, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Mar 30, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Apr 1, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Apr 2, 2026

📣 Hi @aklkv! a backport is missing for this PR [22790] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/all backport/ent/1.18 backport/ent/1.19 backport/ent/1.20 backport/ent/1.21 backport/1.21 theme/ui