Skip to content

Commit e808c1b

Browse files
committed
[Project Solar / Phase 1 / Showcase] Add support for "column" layout to comparison grid and "no equivalent" block (#3682)
1 parent 9d0bab5 commit e808c1b

File tree

10 files changed

+229
-57
lines changed

10 files changed

+229
-57
lines changed

showcase/app/components/page-carbonization/components/application-state/index.gts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const ApplicationStateCarbonizationIndex: TemplateOnlyComponent = <template>
2222

2323
<ShwCarbonizationComparisonGrid
2424
@label="With icon and error code"
25-
@sideBySide={{true}}
25+
@layout="side-by-side"
2626
>
2727
<:theming>
2828
<CodeFragmentWithActionVariants

showcase/app/components/page-carbonization/components/badge/index.gts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,8 @@ const BadgeCarbonizationIndex: TemplateOnlyComponent = <template>
316316
{{/each}}
317317
</ShwFlex>
318318
</:theming>
319-
<:reference>
320-
<code>???</code>
319+
<:reference as |R|>
320+
<R.NoEquivalent @isCompact={{true}} />
321321
</:reference>
322322
</ShwCarbonizationComparisonGrid>
323323

showcase/app/components/page-carbonization/components/form/radio-card/index.gts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export default class FormRadioCardCarbonizationIndex extends Component {
157157

158158
<ShwCarbonizationComparisonGrid
159159
@label="With standard content"
160-
@sideBySide={{true}}
160+
@layout="side-by-side"
161161
>
162162
<:theming as |T|>
163163
<HdsFormRadioCardGroup
@@ -209,7 +209,7 @@ export default class FormRadioCardCarbonizationIndex extends Component {
209209

210210
<ShwCarbonizationComparisonGrid
211211
@label="With helper text, required, error"
212-
@sideBySide={{true}}
212+
@layout="side-by-side"
213213
>
214214
<:theming as |T|>
215215
<HdsFormRadioCardGroup
@@ -269,7 +269,7 @@ export default class FormRadioCardCarbonizationIndex extends Component {
269269
{{#each CONTROL_POSITIONS as |position|}}
270270
<ShwCarbonizationComparisonGrid
271271
@label="Position = {{position}}"
272-
@sideBySide={{true}}
272+
@layout="side-by-side"
273273
>
274274
<:theming as |T|>
275275
<HdsFormRadioCardGroup
@@ -326,7 +326,7 @@ export default class FormRadioCardCarbonizationIndex extends Component {
326326
{{#each ALIGNMENTS as |alignment|}}
327327
<ShwCarbonizationComparisonGrid
328328
@label="Alignment = {{alignment}}"
329-
@sideBySide={{true}}
329+
@layout="side-by-side"
330330
>
331331
<:theming as |T|>
332332
<HdsFormRadioCardGroup
@@ -385,7 +385,7 @@ export default class FormRadioCardCarbonizationIndex extends Component {
385385
{{#each LAYOUT_TYPES as |layout|}}
386386
<ShwCarbonizationComparisonGrid
387387
@label="Layout = {{layout}}"
388-
@sideBySide={{true}}
388+
@layout="side-by-side"
389389
>
390390
<:theming as |T|>
391391
<HdsFormRadioCardGroup

showcase/app/components/page-carbonization/components/modal/index.gts

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
4040
{{#each COLORS as |color|}}
4141
<ShwCarbonizationComparisonGrid
4242
@label={{capitalize color}}
43-
@sideBySide={{true}}
43+
@layout="side-by-side"
4444
>
4545
<:theming>
4646
<HdsModal
@@ -105,7 +105,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
105105

106106
<ShwTextH3>Header</ShwTextH3>
107107

108-
<ShwCarbonizationComparisonGrid @label="With icon" @sideBySide={{true}}>
108+
<ShwCarbonizationComparisonGrid @label="With icon" @layout="side-by-side">
109109
<:theming>
110110
<HdsModal open id="modal-example-icon" @size="small" as |M|>
111111
<M.Header @icon="info">
@@ -145,7 +145,10 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
145145
</:reference>
146146
</ShwCarbonizationComparisonGrid>
147147

148-
<ShwCarbonizationComparisonGrid @label="With tagline" @sideBySide={{true}}>
148+
<ShwCarbonizationComparisonGrid
149+
@label="With tagline"
150+
@layout="side-by-side"
151+
>
149152
<:theming>
150153
<HdsModal open id="modal-example-tagline" @size="small" as |M|>
151154
<M.Header @tagline="Tagline">
@@ -188,7 +191,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
188191

189192
<ShwCarbonizationComparisonGrid
190193
@label="With tagline and icon"
191-
@sideBySide={{true}}
194+
@layout="side-by-side"
192195
>
193196
<:theming>
194197
<HdsModal open id="modal-example-tagline-icon" @size="small" as |M|>
@@ -236,7 +239,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
236239

237240
<ShwCarbonizationComparisonGrid
238241
@label="With basic style"
239-
@sideBySide={{true}}
242+
@layout="side-by-side"
240243
>
241244
<:theming>
242245
<HdsModal open id="modal-example-basic-content" @size="small" as |M|>
@@ -299,7 +302,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
299302

300303
<ShwTextH2>Footer</ShwTextH2>
301304

302-
<ShwCarbonizationComparisonGrid @label="One action" @sideBySide={{true}}>
305+
<ShwCarbonizationComparisonGrid @label="One action" @layout="side-by-side">
303306
<:theming>
304307
<HdsModal open id="modal-example-one-action" @size="small" as |M|>
305308
<M.Header>
@@ -335,7 +338,7 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
335338
</:reference>
336339
</ShwCarbonizationComparisonGrid>
337340

338-
<ShwCarbonizationComparisonGrid @label="Two actions" @sideBySide={{true}}>
341+
<ShwCarbonizationComparisonGrid @label="Two actions" @layout="side-by-side">
339342
<:theming>
340343
<HdsModal open id="modal-example-two-actions" @size="small" as |M|>
341344
<M.Header>
@@ -375,7 +378,10 @@ const ModalCarbonizationIndex: TemplateOnlyComponent = <template>
375378
</:reference>
376379
</ShwCarbonizationComparisonGrid>
377380

378-
<ShwCarbonizationComparisonGrid @label="Three actions" @sideBySide={{true}}>
381+
<ShwCarbonizationComparisonGrid
382+
@label="Three actions"
383+
@layout="side-by-side"
384+
>
379385
<:theming>
380386
<HdsModal open id="modal-example-three-actions" @size="small" as |M|>
381387
<M.Header>

0 commit comments

Comments
 (0)