Skip to content

Commit 3cca945

Browse files
committed
Avoid reusing the same http.Request
1 parent 487a1fa commit 3cca945

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

get_http.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ func (g *HttpGetter) GetFile(dst string, src *url.URL) error {
181181
if fi, err := f.Stat(); err == nil {
182182
if _, err = f.Seek(0, io.SeekEnd); err == nil {
183183
currentFileSize = fi.Size()
184-
req.Header.Set("Range", fmt.Sprintf("bytes=%d-", currentFileSize))
185184
if currentFileSize >= headResp.ContentLength {
186185
// file already present
187186
return nil
@@ -191,7 +190,17 @@ func (g *HttpGetter) GetFile(dst string, src *url.URL) error {
191190
}
192191
}
193192
}
194-
req.Method = "GET"
193+
194+
req, err = http.NewRequest("GET", src.String(), nil)
195+
if err != nil {
196+
return err
197+
}
198+
if g.Header != nil {
199+
req.Header = g.Header.Clone()
200+
}
201+
if currentFileSize > 0 {
202+
req.Header.Set("Range", fmt.Sprintf("bytes=%d-", currentFileSize))
203+
}
195204

196205
resp, err := g.Client.Do(req)
197206
if err != nil {

0 commit comments

Comments
 (0)