Feedback from aaron 👍

Author: kpenfound

.circleci/config.yml

@@ -3,28 +3,29 @@ version: 2.1
 references:
   images:
     go: &GOLANG_IMAGE circleci/golang:latest
+  environments:
+    tmp: &TEST_RESULTS_PATH /tmp/test-results # path to where test results are saved
 
 # reusable 'executor' object for jobs
 executors:
   go:
     docker:
       - image: *GOLANG_IMAGE
     environment:
-      - TEST_RESULTS: /tmp/test-results # path to where test results are saved
+      - TEST_RESULTS: *TEST_RESULTS_PATH
 
 jobs:
-  go-fmt-and-vet:
+  go-fmt-and-test:
     executor: go
     steps:
       - checkout
+      - run: mkdir -p $TEST_RESULTS
 
       # Restore go module cache if there is one
       - restore_cache:
           keys:
             - go-getter-modcache-v1-{{ checksum "go.mod" }}
 
-      - run: go mod download
-
       # Save go module cache if the go.mod file has changed
       - save_cache:
           key: go-getter-modcache-v1-{{ checksum "go.mod" }}
@@ -41,32 +42,18 @@ jobs:
               echo "$files"
               exit 1
             fi
-      - run: go vet ./...
-
-  go-test:
-    executor: go
-    steps:
-      - checkout
-      - run: mkdir -p $TEST_RESULTS
-
-      - restore_cache: # restore cache from dev-build job
-          keys:
-            - go-getter-modcache-v1-{{ checksum "go.mod" }}
 
       # run go tests with gotestsum
       - run: |
           PACKAGE_NAMES=$(go list ./...)
           gotestsum --format=short-verbose --junitfile $TEST_RESULTS/gotestsum-report.xml -- $PACKAGE_NAMES
       - store_test_results:
-          path: /tmp/test-results
+          path: *TEST_RESULTS_PATH
       - store_artifacts:
-          path: /tmp/test-results
+          path: *TEST_RESULTS_PATH
 
 workflows:
   version: 2
   test-and-build:
     jobs:
-      - go-fmt-and-vet
-      - go-test:
-          requires:
-            - go-fmt-and-vet
+      - go-fmt-and-test