Close conn on WriteResponse errors

schmichael · schmichael · commit 325cf76ba50c · 2025-02-07T14:29:49.000-08:00
See hashicorp/net-rpc-msgpackrpc#15 for details.
diff --git a/codec/rpc.go b/codec/rpc.go
@@ -162,7 +162,13 @@ func (c *goRpcCodec) WriteRequest(r *rpc.Request, body interface{}) error {
 }
 
 func (c *goRpcCodec) WriteResponse(r *rpc.Response, body interface{}) error {
-	return c.write(r, body, true)
+	err := c.write(r, body, true)
+	if err != nil {
+		// If error occurred writing a response, close the underlying connection.
+		// See hashicorp/net-rpc-msgpackrpc#15
+		c.Close()
+	}
+	return err
 }
 
 func (c *goRpcCodec) ReadResponseHeader(r *rpc.Response) error {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,13 @@ func (c goRpcCodec) WriteRequest(r rpc.Request, body interface{}) error {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`func (c goRpcCodec) WriteResponse(r rpc.Response, body interface{}) error {`
`165`		`- return c.write(r, body, true)`
	`165`	`+ err := c.write(r, body, true)`
	`166`	`+ if err != nil {`
	`167`	`+ // If error occurred writing a response, close the underlying connection.`
	`168`	`+ // See hashicorp/net-rpc-msgpackrpc#15`
	`169`	`+ c.Close()`
	`170`	`+ }`
	`171`	`+ return err`
`166`	`172`	`}`
`167`	`173`
`168`	`174`	`func (c goRpcCodec) ReadResponseHeader(r rpc.Response) error {`