Skip to content

Commit 404dc51

Browse files
ctrombleyctrombley
committed
chore: rename UpdateConfiguration to FetchConfiguration
1 parent 2edf324 commit 404dc51

7 files changed

+22
-22
lines changed

‎stack.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ type Stacks interface {
3232
// ForceDelete deletes a stack.
3333
ForceDelete(ctx context.Context, stackID string) error
3434

35-
// UpdateConfiguration updates the configuration of a stack, triggering stack preparation.
36-
UpdateConfiguration(ctx context.Context, stackID string) (*Stack, error)
35+
// FetchConfiguration updates the configuration of a stack, triggering stack preparation.
36+
FetchConfiguration(ctx context.Context, stackID string) (*Stack, error)
3737
}
3838

3939
// stacks implements Stacks.
@@ -202,8 +202,8 @@ type WaitForStatusResult struct {
202202
const minimumPollingIntervalMs = 3000
203203
const maximumPollingIntervalMs = 5000
204204

205-
// UpdateConfiguration fetches the latest configuration of a stack from VCS, triggering stack operations
206-
func (s *stacks) UpdateConfiguration(ctx context.Context, stackID string) (*Stack, error) {
205+
// FetchConfiguration fetches the latest configuration of a stack from VCS, triggering stack operations
206+
func (s *stacks) FetchConfiguration(ctx context.Context, stackID string) (*Stack, error) {
207207
req, err := s.client.NewRequest("POST", fmt.Sprintf("stacks/%s/fetch-latest-from-vcs", url.PathEscape(stackID)), nil)
208208
if err != nil {
209209
return nil, err

‎stack_configuration_integration_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ func TestStackConfigurationList(t *testing.T) {
3737
require.NoError(t, err)
3838

3939
// Trigger first stack configuration by updating configuration
40-
_, err = client.Stacks.UpdateConfiguration(ctx, stack.ID)
40+
_, err = client.Stacks.FetchConfiguration(ctx, stack.ID)
4141
require.NoError(t, err)
4242

4343
// Wait a bit and trigger second stack configuration
4444
time.Sleep(2 * time.Second)
45-
_, err = client.Stacks.UpdateConfiguration(ctx, stack.ID)
45+
_, err = client.Stacks.FetchConfiguration(ctx, stack.ID)
4646
require.NoError(t, err)
4747

4848
list, err := client.StackConfigurations.List(ctx, stack.ID, nil)

‎stack_configuration_summary_integration_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ func TestStackConfigurationSummaryList(t *testing.T) {
5050
require.NotNil(t, stack2)
5151

5252
// Trigger first stack configuration by updating configuration
53-
_, err = client.Stacks.UpdateConfiguration(ctx, stack2.ID)
53+
_, err = client.Stacks.FetchConfiguration(ctx, stack2.ID)
5454
require.NoError(t, err)
5555

5656
// Wait a bit and trigger second stack configuration
5757
time.Sleep(2 * time.Second)
58-
_, err = client.Stacks.UpdateConfiguration(ctx, stack2.ID)
58+
_, err = client.Stacks.FetchConfiguration(ctx, stack2.ID)
5959
require.NoError(t, err)
6060

6161
t.Run("Successful empty list", func(t *testing.T) {

‎stack_deployment_groups_integration_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func TestStackDeploymentGroupsList(t *testing.T) {
3636
require.NoError(t, err)
3737
require.NotNil(t, stack)
3838

39-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
39+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
4040
require.NoError(t, err)
4141
require.NotNil(t, stackUpdated)
4242
require.NotEmpty(t, stackUpdated.LatestStackConfiguration.ID)
@@ -102,7 +102,7 @@ func TestStackDeploymentGroupsRead(t *testing.T) {
102102
require.NoError(t, err)
103103
require.NotNil(t, stack)
104104

105-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
105+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
106106
require.NoError(t, err)
107107
require.NotNil(t, stackUpdated)
108108

@@ -154,7 +154,7 @@ func TestStackDeploymentGroupsApproveAllPlans(t *testing.T) {
154154
require.NoError(t, err)
155155
require.NotNil(t, stack)
156156

157-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
157+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
158158
require.NoError(t, err)
159159
require.NotNil(t, stackUpdated)
160160

@@ -201,7 +201,7 @@ func TestStackDeploymentGroupsRerun(t *testing.T) {
201201
require.NoError(t, err)
202202
require.NotNil(t, stack)
203203

204-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
204+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
205205
require.NoError(t, err)
206206
require.NotNil(t, stackUpdated)
207207

‎stack_deployment_runs_integration_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestStackDeploymentRunsList(t *testing.T) {
3838
require.NoError(t, err)
3939
require.NotNil(t, stack)
4040

41-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
41+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
4242
require.NoError(t, err)
4343
require.NotNil(t, stackUpdated)
4444

@@ -98,7 +98,7 @@ func TestStackDeploymentRunsRead(t *testing.T) {
9898
require.NoError(t, err)
9999
require.NotNil(t, stack)
100100

101-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
101+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
102102
require.NoError(t, err)
103103
require.NotNil(t, stackUpdated)
104104

@@ -153,7 +153,7 @@ func TestStackDeploymentRunsApproveAllPlans(t *testing.T) {
153153
require.NoError(t, err)
154154
require.NotNil(t, stack)
155155

156-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
156+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
157157
require.NoError(t, err)
158158
require.NotNil(t, stackUpdated)
159159

@@ -206,7 +206,7 @@ func TestStackDeploymentRunsCancel(t *testing.T) {
206206
require.NoError(t, err)
207207
require.NotNil(t, stack)
208208

209-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
209+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
210210
require.NoError(t, err)
211211
require.NotNil(t, stackUpdated)
212212

‎stack_deployment_steps_integration_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func TestStackDeploymentStepsList(t *testing.T) {
3636
require.NoError(t, err)
3737
require.NotNil(t, stack)
3838

39-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
39+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
4040
require.NoError(t, err)
4141
require.NotNil(t, stackUpdated)
4242

@@ -126,7 +126,7 @@ func TestStackDeploymentStepsRead(t *testing.T) {
126126
require.NoError(t, err)
127127
require.NotNil(t, stack)
128128

129-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
129+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
130130
require.NoError(t, err)
131131
require.NotNil(t, stackUpdated)
132132

@@ -188,7 +188,7 @@ func TestStackDeploymentStepsAdvance(t *testing.T) {
188188
require.NoError(t, err)
189189
require.NotNil(t, stack)
190190

191-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
191+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
192192
require.NoError(t, err)
193193
require.NotNil(t, stackUpdated)
194194

‎stack_integration_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ func TestStackReadUpdateDelete(t *testing.T) {
192192
require.Equal(t, "updated description", stackUpdated.Description)
193193
require.Equal(t, updatedPool.ID, stackUpdated.AgentPool.ID)
194194

195-
stackUpdatedConfig, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
195+
stackUpdatedConfig, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
196196
require.NoError(t, err)
197197
require.Equal(t, stack.Name, stackUpdatedConfig.Name)
198198

@@ -300,7 +300,7 @@ func TestStackReadUpdateForceDelete(t *testing.T) {
300300
require.NoError(t, err)
301301
require.Equal(t, "updated description", stackUpdated.Description)
302302

303-
stackUpdatedConfig, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
303+
stackUpdatedConfig, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
304304
require.NoError(t, err)
305305
require.Equal(t, stack.Name, stackUpdatedConfig.Name)
306306

@@ -441,7 +441,7 @@ func TestStackConverged(t *testing.T) {
441441
require.NoError(t, err)
442442
require.NotNil(t, stack)
443443

444-
stackUpdated, err := client.Stacks.UpdateConfiguration(ctx, stack.ID)
444+
stackUpdated, err := client.Stacks.FetchConfiguration(ctx, stack.ID)
445445
require.NoError(t, err)
446446
require.NotNil(t, stackUpdated)
447447

0 commit comments

Comments
 (0)