Compliance with openapi specs and tests are passing

Author: hwatkins05-hashicorp

stack_deployment_groups.go

@@ -21,28 +21,21 @@ const (
 	DeploymentGroupStatusAbandoned DeploymentGroupStatus = "abandoned"
 )
 
-var DeploymentGroupStatuses = []DeploymentGroupStatus{
-	DeploymentGroupStatusPending,
-	DeploymentGroupStatusDeploying,
-	DeploymentGroupStatusSucceeded,
-	DeploymentGroupStatusFailed,
-	DeploymentGroupStatusAbandoned,
-}
-
 type stackDeploymentGroups struct {
 	client *Client
 }
 
 var _ StackDeploymentGroups = &stackDeploymentGroups{}
 
 type StackDeploymentGroup struct {
-	Id                   string
-	Name                 string
-	Status               DeploymentGroupStatus
-	CreatedAt            string
-	UpdatedAt            string // time.RFC3339
-	StackConfigurationId string
-	FailureCount         int
+	ID        string                
+	Name      string                `jsonapi:"attr,name"`
+	Status    DeploymentGroupStatus `jsonapi:"attr,status"`
+	CreatedAt string                
+	UpdatedAt string                
+
+	// Relationships
+	StackConfiguration StackConfiguration 
 }
 
 // StackDeploymentGroupList represents a list of stack deployment groups.

stack_deployment_groups_integration_test.go

@@ -44,39 +44,34 @@ func TestStackDeploymentGroupsList(t *testing.T) {
 	stackUpdated.LatestStackConfiguration, _ = client.StackConfigurations.Read(ctx, stackUpdated.LatestStackConfiguration.ID)
 
 	t.Run("with valid stack configuration ID", func(t *testing.T) {
-		//t.Parallel()
 		sdgl, err := client.StackDeploymentGroups.List(ctx, stackUpdated.LatestStackConfiguration.ID, nil)
 		require.NoError(t, err)
 		require.NotNil(t, sdgl)
-
 		for _, item := range sdgl.Items {
-			assert.NotNil(t, item.Id)
+			assert.NotNil(t, item.ID)
 			assert.NotEmpty(t, item.Name)
 			assert.NotEmpty(t, item.Status)
 			assert.NotNil(t, item.CreatedAt)
 			assert.NotNil(t, item.UpdatedAt)
-			assert.NotEmpty(t, item.StackConfigurationId)
-			assert.GreaterOrEqual(t, item.FailureCount, 0)
 		}
+		require.Len(t, sdgl.Items, 2)
 	})
 
-	// t.Run("with invalid stack configuration ID", func(t *testing.T) {
-	// 	//t.Parallel()
-	// 	_, err := client.StackDeploymentGroups.List(ctx, "", nil)
-	// 	require.Error(t, err)
-	// })
+	t.Run("with invalid stack configuration ID", func(t *testing.T) {
+		_, err := client.StackDeploymentGroups.List(ctx, "", nil)
+		require.Error(t, err)
+	})
 
-	// t.Run("List with pagination", func(t *testing.T) {
-	// 	t.Parallel()
-	// 	options := &StackDeploymentGroupListOptions{
-	// 		ListOptions: ListOptions{
-	// 			PageNumber: 2,
-	// 			PageSize: 2,
-	// 		},
-	// 	}
-	// 	sdgl, err := client.StackDeploymentGroups.List(ctx, stackUpdated.LatestStackConfiguration.ID, options)
-	// 	require.NoError(t, err)
-	// 	require.NotNil(t, sdgl)
-	// 	require.Len(t, sdgl.Items, 0)
-	// })
+	t.Run("List with pagination", func(t *testing.T) {
+		options := &StackDeploymentGroupListOptions{
+			ListOptions: ListOptions{
+				PageNumber: 1,
+				PageSize:   1,
+			},
+		}
+		sdgl, err := client.StackDeploymentGroups.List(ctx, stackUpdated.LatestStackConfiguration.ID, options)
+		require.NoError(t, err)
+		require.NotNil(t, sdgl)
+		require.Len(t, sdgl.Items, 1)
+	})
 }