Merge pull request #1062 from hashicorp/netramali/TF-23828-remove-feature-flag

Remove beta flag for variable set permission in team project

Author: netramali

team_project_access.go

@@ -72,7 +72,6 @@ type TeamProjectAccessProjectPermissions struct {
 	ProjectSettingsPermission ProjectSettingsPermissionType `jsonapi:"attr,settings"`
 	ProjectTeamsPermission    ProjectTeamsPermissionType    `jsonapi:"attr,teams"`
 	// ProjectVariableSetsPermission represents read, manage, and no access custom permission for project-level variable sets
-	// This relation is considered BETA, SUBJECT TO CHANGE, and likely unavailable to most users.
 	ProjectVariableSetsPermission ProjectVariableSetsPermissionType `jsonapi:"attr,variable-sets"`
 }
 
@@ -108,7 +107,6 @@ const (
 )
 
 // ProjectVariableSetsPermissionType represents the permission type to a project's variable sets
-// This relation is considered BETA, SUBJECT TO CHANGE, and likely unavailable to most users.
 type ProjectVariableSetsPermissionType string
 
 const (
@@ -154,9 +152,8 @@ const (
 )
 
 type TeamProjectAccessProjectPermissionsOptions struct {
-	Settings *ProjectSettingsPermissionType `json:"settings,omitempty"`
-	Teams    *ProjectTeamsPermissionType    `json:"teams,omitempty"`
-	// This relation is considered BETA, SUBJECT TO CHANGE, and likely unavailable to most users.
+	Settings     *ProjectSettingsPermissionType     `json:"settings,omitempty"`
+	Teams        *ProjectTeamsPermissionType        `json:"teams,omitempty"`
 	VariableSets *ProjectVariableSetsPermissionType `json:"variable-sets,omitempty"`
 }
 

team_project_access_integration_test.go

@@ -166,7 +166,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
 	})
 
 	t.Run("with no project access options for custom TeamProject permissions", func(t *testing.T) {
-		skipUnlessBeta(t)
 		options := TeamProjectAccessAddOptions{
 			Access:        *ProjectAccess(TeamProjectAccessCustom),
 			Team:          tmTest,
@@ -274,7 +273,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
 	})
 
 	t.Run("with valid options for custom variable sets permissions", func(t *testing.T) {
-		skipUnlessBeta(t)
 		options := TeamProjectAccessAddOptions{
 			Access:  *ProjectAccess(TeamProjectAccessCustom),
 			Team:    tmTest,
@@ -481,7 +479,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
 	})
 
 	t.Run("with valid custom permissions attributes for variable sets permissions", func(t *testing.T) {
-		skipUnlessBeta(t)
 		// create tpaCustomTest to verify unupdated attributes stay the same for custom permissions
 		// because going from admin to read to custom changes the values of all custom permissions
 		tm2Test, tm2TestCleanup := createTeam(t, client, orgTest)