Skip to content

Commit f448f38

Browse files
committed
Fix Admin SAML settings update tests
1 parent 7ef7f59 commit f448f38

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

admin_setting_saml_integration_test.go

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ func TestAdminSettings_SAML_Update(t *testing.T) {
7070
samlSettingsUpd, err := client.Admin.Settings.SAML.Update(ctx, AdminSAMLSettingsUpdateOptions{
7171
Certificate: String(cert),
7272
PrivateKey: String(pKey),
73+
IDPCert: String(cert),
74+
SLOEndpointURL: String("https://example.com/slo"),
75+
SSOEndpointURL: String("https://example.com/sso"),
7376
SignatureSigningMethod: String(signatureSigningMethod),
7477
SignatureDigestMethod: String(signatureDigestMethod),
7578
})
@@ -81,23 +84,34 @@ func TestAdminSettings_SAML_Update(t *testing.T) {
8184
})
8285

8386
t.Run("with team management enabled", func(t *testing.T) {
87+
cert := "testCert"
88+
pKey := "testPrivateKey"
89+
signatureSigningMethod := "SHA1"
90+
signatureDigestMethod := "SHA1"
91+
8492
samlSettingsUpd, err := client.Admin.Settings.SAML.Update(ctx, AdminSAMLSettingsUpdateOptions{
85-
Enabled: Bool(true),
86-
TeamManagementEnabled: Bool(true),
93+
Enabled: Bool(true),
94+
TeamManagementEnabled: Bool(true),
95+
Certificate: String(cert),
96+
PrivateKey: String(pKey),
97+
SignatureSigningMethod: String(signatureSigningMethod),
98+
SignatureDigestMethod: String(signatureDigestMethod),
8799
})
88100
require.NoError(t, err)
89101
assert.True(t, samlSettingsUpd.TeamManagementEnabled)
90102
})
91103

92104
t.Run("with invalid signature digest method", func(t *testing.T) {
93105
_, err := client.Admin.Settings.SAML.Update(ctx, AdminSAMLSettingsUpdateOptions{
106+
AuthnRequestsSigned: Bool(true),
94107
SignatureDigestMethod: String("SHA1234"),
95108
})
96109
require.Error(t, err)
97110
})
98111

99112
t.Run("with invalid signature signing method", func(t *testing.T) {
100113
_, err := client.Admin.Settings.SAML.Update(ctx, AdminSAMLSettingsUpdateOptions{
114+
AuthnRequestsSigned: Bool(true),
101115
SignatureSigningMethod: String("SHA1234"),
102116
})
103117
require.Error(t, err)

0 commit comments

Comments
 (0)