Apply suggestions from code review

Co-authored-by: Radek Simko <[email protected]>

Author: jpogran

decoder/body_candidates.go

@@ -18,9 +18,9 @@ func (d *PathDecoder) bodySchemaCandidates(body *hclsyntax.Body, schema *schema.
 	count := 0
 
 	if schema.Extensions != nil {
-		// check if this schema supports Count attribute
+		// check if count attribute "extension" is enabled here
 		if schema.Extensions.Count {
-			// check if Count is already used inside this body, so we don't
+			// check if count attribute is already declared, so we don't
 			// suggest a duplicate
 			if _, ok := body.Attributes["count"]; !ok {
 				candidates.List = append(candidates.List, countAttributeCandidate(editRng))

decoder/hover_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/zclconf/go-cty-debug/ctydebug"
 	"github.com/zclconf/go-cty/cty"
-
 	"github.com/hashicorp/hcl-lang/lang"
 	"github.com/hashicorp/hcl-lang/schema"
 	"github.com/hashicorp/hcl/v2"
@@ -935,7 +934,7 @@ func TestDecoder_HoverAtPos_typeDeclaration(t *testing.T) {
 	}
 }
 
-func TestDecoder_HoverAtPos_expression_extension(t *testing.T) {
+func TestDecoder_HoverAtPos_extension(t *testing.T) {
 	resourceLabelSchema := []*schema.LabelSchema{
 		{Name: "type", IsDepKey: true},
 		{Name: "name"},

decoder/semantic_tokens.go

@@ -5,7 +5,6 @@ import (
 	"sort"
 
 	"github.com/zclconf/go-cty/cty"
-
 	icontext "github.com/hashicorp/hcl-lang/context"
 	"github.com/hashicorp/hcl-lang/lang"
 	"github.com/hashicorp/hcl-lang/reference"
@@ -62,10 +61,6 @@ func (d *PathDecoder) tokensForBody(ctx context.Context, body *hclsyntax.Body, b
 		if !ok {
 			if bodySchema.Extensions != nil && name == "count" && bodySchema.Extensions.Count {
 				attrSchema = &schema.AttributeSchema{
-					Description: lang.MarkupContent{
-						Kind:  lang.MarkdownKind,
-						Value: "**count** _optional, number_\n\nThe distinct index number (starting with 0) corresponding to the instance",
-					},
 					IsOptional: true,
 					Expr:       schema.LiteralTypeOnly(cty.Number),
 				}

decoder/semantic_tokens_expr_test.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/zclconf/go-cty/cty"
-
 	"github.com/hashicorp/hcl-lang/lang"
 	"github.com/hashicorp/hcl-lang/reference"
 	"github.com/hashicorp/hcl-lang/schema"

schema/body_schema.go

@@ -52,9 +52,6 @@ type BodySchema struct {
 
 type BodyExtensions struct {
 	Count         bool // count attribute + count.index refs
-	ForEach       bool // for_each attribute + each.* refs
-	DynamicBlocks bool // dynamic "block-name" w/ content & for_each inside
-	SelfRefs      bool // self.* refs which refer to outermost parent block body
 }
 
 func (be *BodyExtensions) Copy() *BodyExtensions {