Apply suggestions from code review

Co-authored-by: Radek Simko <[email protected]>

Author: jpogran

decoder/candidates_test.go

@@ -8,7 +8,6 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-
 	"github.com/hashicorp/hcl-lang/lang"
 	"github.com/hashicorp/hcl-lang/schema"
 	"github.com/hashicorp/hcl/v2"

decoder/hover.go

@@ -248,7 +248,10 @@ func (d *PathDecoder) hoverDataForExpr(ctx context.Context, expr hcl.Expression,
 			}, nil
 		}
 
-		address, _ := lang.TraversalToAddress(e.AsTraversal())
+		address, err := lang.TraversalToAddress(e.AsTraversal())
+		if err != nil {
+			return nil, err
+		}
 		if address.Equals(lang.Address{
 			lang.RootStep{
 				Name: "count",

decoder/hover_test.go

@@ -974,7 +974,10 @@ func TestDecoder_HoverAtPos_extension(t *testing.T) {
 }
 `)
 
-	f, _ := hclsyntax.ParseConfig(testConfig, "test.tf", hcl.InitialPos)
+	f, err := hclsyntax.ParseConfig(testConfig, "test.tf", hcl.InitialPos)
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	d := testPathDecoder(t, &PathContext{
 		Schema: bodySchema,

decoder/semantic_tokens.go

@@ -160,7 +160,10 @@ func (d *PathDecoder) tokensForExpression(ctx context.Context, expr hclsyntax.Ex
 			}
 		}
 
-		address, _ := lang.TraversalToAddress(eType.AsTraversal())
+		address, err := lang.TraversalToAddress(eType.AsTraversal())
+		if err != nil {
+			return tokens
+		}
 		countAvailable := schema.ActiveCountFromContext(ctx)
 		countIndexAttr := lang.Address{
 			lang.RootStep{