🐞TFECO-11466 Add new user interaction status and unit tests (#694)

* TFECO-11466 Add new user interaction status and unit tests

* Add change log

Author: Shweta-Deshpande

.changes/unreleased/BUG FIXES-694-20260114-203020.yaml

@@ -0,0 +1,5 @@
+kind: BUG FIXES
+body: 'PendingRuns: This change fixes the unnecessary agent pods created for pending runs by adding a missing status in the user interaction statuses map'
+time: 2026-01-14T20:30:20.800288-08:00
+custom:
+    PR: "694"

internal/controller/agentpool_controller_autoscaling.go

@@ -26,6 +26,7 @@ var userInteractionRunStatuses = map[tfc.RunStatus]struct{}{
 	tfc.RunPolicyOverride:           {},
 	tfc.RunPostPlanAwaitingDecision: {},
 	tfc.RunPostPlanCompleted:        {},
+	tfc.RunPending:                  {},
 }
 
 // matchWildcardName checks if a given string matches a specified wildcard pattern.
@@ -80,6 +81,7 @@ func pendingRuns(ctx context.Context, ap *agentPoolInstance) (int32, error) {
 		if err != nil {
 			return 0, err
 		}
+
 		for _, run := range runsList.Items {
 			// Skip runs that require user interaction
 			if _, ok := userInteractionRunStatuses[run.Status]; ok {

internal/controller/agentpool_controller_autoscaling_test.go

@@ -126,6 +126,30 @@ func TestPendingRuns(t *testing.T) {
 			expectedCount: 4,
 			expectError:   false,
 		},
+		{
+			name: "plan-only runs that might have a pending status",
+			mockRuns: []*tfc.Run{
+				{ID: "run1", PlanOnly: true, Status: tfc.RunPending, Workspace: &tfc.Workspace{ID: "ws2"}},
+				{ID: "run2", PlanOnly: true, Status: tfc.RunPlanning, Workspace: &tfc.Workspace{ID: "ws2"}},
+				{ID: "run3", PlanOnly: true, Status: tfc.RunPlanning, Workspace: &tfc.Workspace{ID: "ws2"}},
+				{ID: "run4", PlanOnly: true, Status: tfc.RunPlanning, Workspace: &tfc.Workspace{ID: "ws2"}},
+				{ID: "run5", PlanOnly: true, Status: tfc.RunPending, Workspace: &tfc.Workspace{ID: "ws2"}},
+			},
+			expectedCount: 3,
+			expectError:   false,
+		},
+		{
+			name: "mix of plan-only and apply runs that might have user interaction statuses",
+			mockRuns: []*tfc.Run{
+				{ID: "run1", PlanOnly: true, Status: tfc.RunPlanning, Workspace: &tfc.Workspace{ID: "ws1"}},
+				{ID: "run2", PlanOnly: false, Status: tfc.RunPlanned, Workspace: &tfc.Workspace{ID: "ws1"}},
+				{ID: "run3", PlanOnly: true, Status: tfc.RunPending, Workspace: &tfc.Workspace{ID: "ws1"}},
+				{ID: "run4", PlanOnly: false, Status: tfc.RunCostEstimated, Workspace: &tfc.Workspace{ID: "ws1"}},
+				{ID: "run5", PlanOnly: false, Status: tfc.RunPending, Workspace: &tfc.Workspace{ID: "ws1"}},
+			},
+			expectedCount: 1,
+			expectError:   false,
+		},
 	}
 
 	for _, tt := range tests {