chore: incorporate review feedback

Author: ctrombley

nullable.go

@@ -2,7 +2,6 @@ package jsonapi
 
 import (
 	"errors"
-	"time"
 )
 
 // NullableAttr is a generic type, which implements a field that can be one of three states:
@@ -88,19 +87,3 @@ func (t NullableAttr[T]) IsSpecified() bool {
 func (t *NullableAttr[T]) SetUnspecified() {
 	*t = map[bool]T{}
 }
-
-func NullableBool(v bool) NullableAttr[bool] {
-	return NewNullableAttrWithValue[bool](v)
-}
-
-func NullBool() NullableAttr[bool] {
-	return NewNullNullableAttr[bool]()
-}
-
-func NullableTime(v time.Time) NullableAttr[time.Time] {
-	return NewNullableAttrWithValue[time.Time](v)
-}
-
-func NullTime() NullableAttr[time.Time] {
-	return NewNullNullableAttr[time.Time]()
-}

request.go

@@ -668,10 +668,8 @@ func handleNullable(
 	structField reflect.StructField,
 	fieldValue reflect.Value) (reflect.Value, error) {
 
-	if a, ok := attribute.(string); ok {
-		if bytes.Equal([]byte(a), []byte("null")) {
-			return reflect.ValueOf(nil), nil
-		}
+	if a, ok := attribute.(string); ok && a == "null" {
+		return reflect.ValueOf(nil), nil
 	}
 
 	innerType := fieldValue.Type().Elem()
@@ -682,7 +680,7 @@ func handleNullable(
 		return reflect.ValueOf(nil), err
 	}
 
-	fieldValue.Set(reflect.MakeMap(fieldValue.Type()))
+	fieldValue.Set(reflect.MakeMapWithSize(fieldValue.Type(), 1))
 	fieldValue.SetMapIndex(reflect.ValueOf(true), attrVal)
 
 	return fieldValue, nil

response_test.go

@@ -846,7 +846,7 @@ func TestNullableAttr_Time(t *testing.T) {
 			desc: "time_null",
 			input: &WithNullableAttrs{
 				ID:          5,
-				RFC3339Time: NullTime(),
+				RFC3339Time: NewNullNullableAttr[time.Time](),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["rfc3339_time"]
@@ -860,7 +860,7 @@ func TestNullableAttr_Time(t *testing.T) {
 			desc: "time_not_null_rfc3339",
 			input: &WithNullableAttrs{
 				ID:          5,
-				RFC3339Time: NullableTime(aTime),
+				RFC3339Time: NewNullableAttrWithValue[time.Time](aTime),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["rfc3339_time"].(string)
@@ -874,7 +874,7 @@ func TestNullableAttr_Time(t *testing.T) {
 			desc: "time_not_null_iso8601",
 			input: &WithNullableAttrs{
 				ID:          5,
-				ISO8601Time: NullableTime(aTime),
+				ISO8601Time: NewNullableAttrWithValue[time.Time](aTime),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["iso8601_time"].(string)
@@ -888,7 +888,7 @@ func TestNullableAttr_Time(t *testing.T) {
 			desc: "time_not_null_int",
 			input: &WithNullableAttrs{
 				ID:      5,
-				IntTime: NullableTime(aTime),
+				IntTime: NewNullableAttrWithValue[time.Time](aTime),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["int_time"].(float64)
@@ -941,7 +941,7 @@ func TestNullableAttr_Bool(t *testing.T) {
 			desc: "bool_null",
 			input: &WithNullableAttrs{
 				ID:   5,
-				Bool: NullBool(),
+				Bool: NewNullNullableAttr[bool](),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["bool"]
@@ -955,7 +955,7 @@ func TestNullableAttr_Bool(t *testing.T) {
 			desc: "bool_not_null",
 			input: &WithNullableAttrs{
 				ID:   5,
-				Bool: NullableBool(aBool),
+				Bool: NewNullableAttrWithValue[bool](aBool),
 			},
 			verification: func(root map[string]interface{}) error {
 				v := root["data"].(map[string]interface{})["attributes"].(map[string]interface{})["bool"].(bool)