Skip to content

QEMU: Correct graceful_shutdown logic #27316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mismithhisler merged 1 commit into from
Jan 7, 2026
Merged

QEMU: Correct graceful_shutdown logic #27316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/27316.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
qemu: fixes graceful_shutdown to wait kill_timeout before signalling process
```
22 changes: 20 additions & 2 deletions drivers/qemu/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,8 +722,26 @@ func (d *Driver) StopTask(taskID string, timeout time.Duration, signal string) e

// Attempt a graceful shutdown only if it was configured in the job
if handle.monitorPath != "" {
if err := sendQemuShutdown(d.logger, handle.monitorPath, handle.pid); err != nil {
d.logger.Debug("error sending graceful shutdown ", "pid", handle.pid, "error", err)
err := sendQemuShutdown(d.logger, handle.monitorPath, handle.pid)
if err == nil {
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ticker := time.NewTicker(1 * time.Second)
defer ticker.Stop()
out:
for {
select {
case <-ctx.Done():
d.logger.Error("graceful shutdown", "pid", handle.pid, "timeout after", timeout)
break out
case <-ticker.C:
if handle.procState != drivers.TaskStateRunning {
break out
}
}
}
} else {
d.logger.Debug("error sending graceful shutdown", "pid", handle.pid, "error", err)
}
} else {
d.logger.Debug("monitor socket is empty, forcing shutdown")
Expand Down