add tests for updated Set and SetAtPath functionality

Author: stephybun

internal/fwschemadata/data_set_at_path.go

@@ -31,30 +31,45 @@ func (d *Data) SetAtPath(ctx context.Context, path path.Path, val interface{}) d
 	ctx = logging.FrameworkWithAttributePath(ctx, path.String())
 
 	if v, ok := val.(tftypes.Value); ok {
-		atPath, err := d.Schema.AttributeAtPath(ctx, path)
-		if err != nil {
+		atPath, atPathDiags := d.Schema.AttributeAtPath(ctx, path)
+
+		diags.Append(atPathDiags...)
+
+		if diags.HasError() {
+			return diags
+		}
+
+		attrType := atPath.GetType().TerraformType(ctx)
+
+		if !attrType.Equal(v.Type()) {
 			diags.AddAttributeError(
 				path,
 				d.Description.Title()+" Write Error",
 				"An unexpected error was encountered trying to write the "+d.Description.String()+". This is always an error in the provider. Please report the following to the provider developer:\n\n"+
-					fmt.Sprintf("Error: %s does not exist at path", path.String()),
+					fmt.Sprintf("Error: Type of provided value does not match type of %s", path.String()),
 			)
 			return diags
 		}
 
-		attrType := atPath.GetType().TerraformType(ctx)
+		transformFunc, transformFuncDiags := d.SetAtPathTransformFunc(ctx, path, v, nil)
+		diags.Append(transformFuncDiags...)
 
-		if !attrType.Equal(v.Type()) {
+		if diags.HasError() {
+			return diags
+		}
+
+		tfVal, err := tftypes.Transform(d.TerraformValue, transformFunc)
+		if err != nil {
 			diags.AddAttributeError(
 				path,
 				d.Description.Title()+" Write Error",
-				"An unexpected error was encountered trying to write the "+d.Description.String()+". This is always an error in the provider. Please report the following to the provider developer:\n\n"+
-					fmt.Sprintf("Error: Type of provided value does not match type of %s", path.String()),
+				"An unexpected error was encountered trying to write an attribute to the "+d.Description.String()+". This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+					"Error: Cannot transform data: "+err.Error(),
 			)
 			return diags
 		}
 
-		d.TerraformValue = v
+		d.TerraformValue = tfVal
 
 		return diags
 	}

internal/fwschemadata/data_set_at_path_test.go

@@ -2924,6 +2924,39 @@ func TestDataSetAtPath(t *testing.T) {
 				"other": tftypes.NewValue(tftypes.DynamicPseudoType, nil),
 			}),
 		},
+		"write-tftypes-value": {
+			data: fwschemadata.Data{
+				TerraformValue: tftypes.NewValue(tftypes.Object{
+					AttributeTypes: map[string]tftypes.Type{
+						"test":  tftypes.String,
+						"other": tftypes.String,
+					},
+				}, nil),
+				Schema: testschema.Schema{
+					Attributes: map[string]fwschema.Attribute{
+						"test": testschema.Attribute{
+							Type:     types.StringType,
+							Required: true,
+						},
+						"other": testschema.Attribute{
+							Type:     types.StringType,
+							Required: true,
+						},
+					},
+				},
+			},
+			path: path.Root("test"),
+			val:  tftypes.NewValue(tftypes.String, "newvalue"),
+			expected: tftypes.NewValue(tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"test":  tftypes.String,
+					"other": tftypes.String,
+				},
+			}, map[string]tftypes.Value{
+				"test":  tftypes.NewValue(tftypes.String, "newvalue"),
+				"other": tftypes.NewValue(tftypes.String, nil),
+			}),
+		},
 		"AttrTypeWithValidateError": {
 			data: fwschemadata.Data{
 				TerraformValue: tftypes.NewValue(tftypes.Object{

internal/fwschemadata/data_set_test.go

@@ -139,6 +139,39 @@ func TestDataSet(t *testing.T) {
 				),
 			}),
 		},
+		"write-tftypes-values": {
+			data: fwschemadata.Data{
+				TerraformValue: tftypes.NewValue(tftypes.Object{
+					AttributeTypes: map[string]tftypes.Type{
+						"name": tftypes.String,
+					},
+				}, map[string]tftypes.Value{
+					"name": tftypes.NewValue(tftypes.String, "oldvalue"),
+				}),
+				Schema: testschema.Schema{
+					Attributes: map[string]fwschema.Attribute{
+						"name": testschema.Attribute{
+							Type:     types.StringType,
+							Required: true,
+						},
+					},
+				},
+			},
+			val: tftypes.NewValue(tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"name": tftypes.String,
+				},
+			}, map[string]tftypes.Value{
+				"name": tftypes.NewValue(tftypes.String, "newvalue"),
+			}),
+			expected: tftypes.NewValue(tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"name": tftypes.String,
+				},
+			}, map[string]tftypes.Value{
+				"name": tftypes.NewValue(tftypes.String, "newvalue"),
+			}),
+		},
 		"overwrite": {
 			data: fwschemadata.Data{
 				TerraformValue: tftypes.Value{},