ListResource: tidy diagnostic messages

bbasata · bbasata · commit 6075e3f1caa8 · 2025-06-19T15:24:09.000-04:00
diff --git a/internal/fwserver/server_listresource.go b/internal/fwserver/server_listresource.go
@@ -130,7 +130,8 @@ func processListResult(req list.ListRequest, result list.ListResult) ListResult
 	if result.Identity == nil { // TODO: is result.Identity.Raw.IsNull() a practical concern?
 		return ListResultError(
 			"Incomplete List Result",
-			"The provider did not populate the Identity field in the ListResourceResult. This may be due to an error in the provider's implementation.",
+			"The provider did not populate the Identity field in the ListResourceResult. "+
+				"This is always a problem with the provider.  Please report this to the provider developer.",
 		)
 	}
 
diff --git a/internal/fwserver/server_listresource_test.go b/internal/fwserver/server_listresource_test.go
@@ -208,7 +208,7 @@ func TestServerListResource(t *testing.T) {
 					Diagnostics: diag.Diagnostics{
 						diag.NewErrorDiagnostic(
 							"Incomplete List Result",
-							"The provider did not populate the Identity field in the ListResourceResult. This may be due to an error in the provider's implementation.",
+							"The provider did not populate the Identity field in the ListResourceResult. This is always a problem with the provider.  Please report this to the provider developer.",
 						),
 					},
 				},

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,8 @@ func processListResult(req list.ListRequest, result list.ListResult) ListResult`
`130`	`130`	`if result.Identity == nil { // TODO: is result.Identity.Raw.IsNull() a practical concern?`
`131`	`131`	`return ListResultError(`
`132`	`132`	`"Incomplete List Result",`
`133`		`- "The provider did not populate the Identity field in the ListResourceResult. This may be due to an error in the provider's implementation.",`
	`133`	`+ "The provider did not populate the Identity field in the ListResourceResult. "+`
	`134`	`+ "This is always a problem with the provider. Please report this to the provider developer.",`
`134`	`135`	`)`
`135`	`136`	`}`
`136`	`137`