simplify

Author: bbasata

internal/fwserver/server_listresource_test.go

@@ -83,7 +83,7 @@ func TestServerListResource(t *testing.T) {
 			request: &fwserver.ListRequest{
 				ListResource: &testprovider.ListResource{
 					ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) { // TODO
-						resp.Results = slices.Values([]list.ListResult{})
+						resp.Results = list.NoListResults
 					},
 				},
 			},
@@ -110,7 +110,7 @@ func TestServerListResource(t *testing.T) {
 			request: &fwserver.ListRequest{
 				ListResource: &testprovider.ListResource{
 					ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) { // TODO
-						resp.Results = slices.Values([]list.ListResult{
+						resp.Results = list.FromValues([]list.ListResult{
 							{
 								Identity: &tfsdk.ResourceIdentity{
 									Schema: testIdentitySchema,

list/list_resource.go

@@ -5,6 +5,7 @@ package list
 
 import (
 	"context"
+	"slices"
 
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
@@ -104,9 +105,7 @@ type ListRequest struct {
 // that pushes zero or more results of type ListResult.
 //
 // For convenience, a provider implementation may choose to convert a slice of
-// results into an iterator using [slices.Values].
-//
-// [slices.Values]: https://pkg.go.dev/slices#Values
+// results into an iterator using [list.FromValues].
 type ListResultsStream struct {
 	// Results is a function that emits ListResult values via its push
 	// function argument.
@@ -120,6 +119,12 @@ type ListResults func(push func(ListResult) bool)
 
 var NoListResults = func(func(ListResult) bool) {}
 
+// FromValues converts a slice of ListResult values into a ListResults
+// iterator for streaming.
+func FromValues(values []ListResult) ListResults {
+	return ListResults(slices.Values(values))
+}
+
 // ListResult represents a listed managed resource instance.
 type ListResult struct {
 	// Identity is the identity of the managed resource instance.