review comments

Author: stephybun

internal/fwserver/server_getmetadata_test.go

@@ -839,7 +839,7 @@ func TestServerGetMetadata(t *testing.T) {
 					diag.NewErrorDiagnostic(
 						"ListResource Type Defined without a Matching Managed Resource Type",
 						"The test_resource_1 ListResource type name was returned, but no matching managed Resource type was defined. "+
-							"If the matching managed Resource type not a framework resource either ProtoV5Schema and ProtoV5IdentitySchema must be specified in the RawV5Schemas method, "+
+							"If the matching managed Resource type is not a framework resource either ProtoV5Schema and ProtoV5IdentitySchema must be specified in the RawV5Schemas method, "+
 							"or ProtoV6Schema and ProtoV6IdentitySchema must be specified in the RawV6Schemas method. "+
 							"This is always an issue with the provider and should be reported to the provider developers.",
 					),

internal/fwserver/server_listresources.go

@@ -101,7 +101,7 @@ func (s *Server) ListResourceFuncs(ctx context.Context) (map[string]func() list.
 				s.listResourceFuncsDiags.AddError(
 					"ListResource Type Defined without a Matching Managed Resource Type",
 					fmt.Sprintf("The %s ListResource type name was returned, but no matching managed Resource type was defined. ", typeName)+
-						"If the matching managed Resource type not a framework resource either ProtoV5Schema and ProtoV5IdentitySchema must be specified in the RawV5Schemas method, "+
+						"If the matching managed Resource type is not a framework resource either ProtoV5Schema and ProtoV5IdentitySchema must be specified in the RawV5Schemas method, "+
 						"or ProtoV6Schema and ProtoV6IdentitySchema must be specified in the RawV6Schemas method. "+
 						"This is always an issue with the provider and should be reported to the provider developers.",
 				)

list/list_resource.go

@@ -45,7 +45,7 @@ type ListResource interface {
 
 // ListResourceWithRawV5Schemas is an interface type that extends ListResource to include a method
 // which allows provider developers to supply the ProtoV5 representations of resource and resource identity
-// schemas. This is necessary if list functionality is being used with a legacy resource.
+// schemas. This is necessary if list functionality is being used with a resource that is not defined with Framework.
 type ListResourceWithRawV5Schemas interface {
 	ListResource
 
@@ -54,12 +54,12 @@ type ListResourceWithRawV5Schemas interface {
 }
 
 // ListResourceWithRawV6Schemas is an interface type that extends ListResource to include a method
-// which allows provider developers to supply the ProtoV5 representations of resource and resource identity
-// schemas. This is necessary if list functionality is being used with a legacy resource.
+// which allows provider developers to supply the ProtoV6 representations of resource and resource identity
+// schemas. This is necessary if list functionality is being used with a resource that is not defined with Framework.
 type ListResourceWithRawV6Schemas interface {
 	ListResource
 
-	// RawV6Schemas is called to provide the ProtoV5 representations of the resource and resource identity schemas.
+	// RawV6Schemas is called to provide the ProtoV6 representations of the resource and resource identity schemas.
 	RawV6Schemas(context.Context, RawV6SchemaRequest, *RawV6SchemaResponse)
 }
 
@@ -209,7 +209,7 @@ type ListResult struct {
 // to the ListResource type RawV5Schemas method.
 type RawV5SchemaRequest struct{}
 
-// RawV5SchemaResponse represents a response that is populated by the Schemas method
+// RawV5SchemaResponse represents a response that is populated by the RawV5Schemas method
 // and is used to pass along the ProtoV5 representations of the resource and resource identity schemas.
 type RawV5SchemaResponse struct {
 	// ProtoV5IdentitySchema is the ProtoV5 representation of the resource identity
@@ -224,19 +224,19 @@ type RawV5SchemaResponse struct {
 }
 
 // RawV6SchemaRequest represents a request for the ListResource to return the
-// ProtoV5 schemas. An instance of this request struct is supplied as an argument
-// to the ListResource type RawV5Schemas method.
+// ProtoV6 schemas. An instance of this request struct is supplied as an argument
+// to the ListResource type RawV6Schemas method.
 type RawV6SchemaRequest struct{}
 
-// RawV6SchemaResponse represents a response that is populated by the Schemas method
-// and is used to pass along the ProtoV5 representations of the resource and resource identity schemas.
+// RawV6SchemaResponse represents a response that is populated by the RawV6Schemas method
+// and is used to pass along the ProtoV6 representations of the resource and resource identity schemas.
 type RawV6SchemaResponse struct {
-	// ProtoV5IdentitySchema is the ProtoV5 representation of the resource identity
+	// ProtoV6IdentitySchema is the ProtoV6 representation of the resource identity
 	// schema. This should only be supplied if framework functionality is being used
 	// with a legacy resource. Currently, this only applies to list.
 	ProtoV6IdentitySchema *tfprotov6.ResourceIdentitySchema
 
-	// ProtoV5Schema is the ProtoV5 representation of the resource schema
+	// ProtoV6Schema is the ProtoV6 representation of the resource schema
 	// This should only be supplied if framework functionality is being used
 	// with a legacy resource. Currently, this only applies to list.
 	ProtoV6Schema *tfprotov6.Schema