add tests for not null refinement

Author: austinvalle

internal/fwserver/attribute_validation.go

@@ -140,11 +140,10 @@ func AttributeValidate(ctx context.Context, a fwschema.Attribute, req ValidateAt
 	// Show deprecation warnings only for known values or unknown values with a "not null" refinement.
 	if a.GetDeprecationMessage() != "" {
 		if attributeConfig.IsUnknown() {
-			// If the attr.Value supports checking for refinements, we should check if the eventual known value will be not null.
+			// If the unknown value will eventually be not null, we return the deprecation message for the practitioner.
 			val, ok := attributeConfig.(attr.ValueWithNotNullRefinement)
 			if ok {
 				if _, notNull := val.NotNullRefinement(); notNull {
-					// If the unknown value will eventually be not null, we return the deprecation message for the practitioner.
 					resp.Diagnostics.AddAttributeWarning(
 						req.AttributePath,
 						"Attribute Deprecated",

internal/fwserver/attribute_validation_test.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
+	tfrefinement "github.com/hashicorp/terraform-plugin-go/tftypes/refinement"
 
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
@@ -490,6 +491,40 @@ func TestAttributeValidate(t *testing.T) {
 			},
 			resp: ValidateAttributeResponse{},
 		},
+		"deprecation-message-unknown-with-not-null-refinement": {
+			req: ValidateAttributeRequest{
+				AttributePath: path.Root("test"),
+				Config: tfsdk.Config{
+					Raw: tftypes.NewValue(tftypes.Object{
+						AttributeTypes: map[string]tftypes.Type{
+							"test": tftypes.String,
+						},
+					}, map[string]tftypes.Value{
+						"test": tftypes.NewValue(tftypes.String, tftypes.UnknownValue).Refine(tfrefinement.Refinements{
+							tfrefinement.KeyNullness: tfrefinement.NewNullness(false),
+						}),
+					}),
+					Schema: testschema.Schema{
+						Attributes: map[string]fwschema.Attribute{
+							"test": testschema.Attribute{
+								Type:               types.StringType,
+								Optional:           true,
+								DeprecationMessage: "Use something else instead.",
+							},
+						},
+					},
+				},
+			},
+			resp: ValidateAttributeResponse{
+				Diagnostics: diag.Diagnostics{
+					diag.NewAttributeWarningDiagnostic(
+						path.Root("test"),
+						"Attribute Deprecated",
+						"Use something else instead.",
+					),
+				},
+			},
+		},
 		"deprecation-message-dynamic-underlying-value-unknown": {
 			req: ValidateAttributeRequest{
 				AttributePath: path.Root("test"),