Add error & warning cases to fwserver listresource test

Author: bbasata

internal/fwserver/server_listresource_test.go

@@ -102,7 +102,6 @@ func TestServerListResource(t *testing.T) {
 			},
 			expectedStreamEvents: []fwserver.ListResult{},
 		},
-
 		"success-with-multiple-results": {
 			server: &fwserver.Server{
 				Provider: &testprovider.Provider{},
@@ -166,6 +165,74 @@ func TestServerListResource(t *testing.T) {
 				},
 			},
 		},
+		"error-on-missing-resource-identity": {
+			server: &fwserver.Server{
+				Provider: &testprovider.Provider{},
+			},
+			request: &fwserver.ListRequest{
+				ListResource: &testprovider.ListResource{
+					ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) { // TODO
+						resp.Results = slices.Values([]list.ListResult{
+							{
+								Identity: nil,
+								Resource: &tfsdk.Resource{
+									Schema: testSchema,
+									Raw:    testResourceValue1,
+								},
+								DisplayName: "Test Resource 1",
+							},
+						})
+					},
+				},
+			},
+			expectedStreamEvents: []fwserver.ListResult{
+				{
+					Diagnostics: diag.Diagnostics{
+						diag.NewErrorDiagnostic(
+							"Incomplete List Result",
+							"The provider did not populate the Identity field in the ListResourceResult. This may be due to an error in the provider's implementation.",
+						),
+					},
+				},
+			},
+		},
+		"warning-on-missing-resource": {
+			server: &fwserver.Server{
+				Provider: &testprovider.Provider{},
+			},
+			request: &fwserver.ListRequest{
+				IncludeResource: true,
+				ListResource: &testprovider.ListResource{
+					ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) {
+						resp.Results = slices.Values([]list.ListResult{
+							{
+								Identity: &tfsdk.ResourceIdentity{
+									Schema: testIdentitySchema,
+									Raw:    testIdentityValue1,
+								},
+								Resource:    nil,
+								DisplayName: "Test Resource 1",
+							},
+						})
+					},
+				},
+			},
+			expectedStreamEvents: []fwserver.ListResult{
+				{
+					Identity: &tfsdk.ResourceIdentity{
+						Schema: testIdentitySchema,
+						Raw:    testIdentityValue1,
+					},
+					DisplayName: "Test Resource 1",
+					Diagnostics: diag.Diagnostics{
+						diag.NewWarningDiagnostic(
+							"Incomplete List Result",
+							"The provider did not populate the Resource field in the ListResourceResult. This may be due to the provider not supporting this functionality or an error in the provider's implementation.",
+						),
+					},
+				},
+			},
+		},
 	}
 
 	for name, testCase := range testCases {

internal/proto6server/server_listresource.go

@@ -13,13 +13,11 @@ func (s *Server) ListResource(ctx context.Context, proto6Req *tfprotov6.ListReso
 	// proto6Stream := &tfprotov6.ListResourceServerStream{Results: tfprotov6.NoListResults}
 	proto6Stream := &tfprotov6.ListResourceServerStream{Results: func(func(tfprotov6.ListResourceResult) bool) {}}
 
-	// TODO: extract fromproto6.ListRequest
 	listResource, err := s.FrameworkServer.ListResourceOrError(ctx, proto6Req.TypeName)
 	if err != nil {
 		return proto6Stream, err
 	}
 
-	// TODO: extract fromproto6.ListResourceConfig
 	listResourceSchema, diags := s.FrameworkServer.ListResourceSchema(ctx, proto6Req.TypeName)
 	if diags.HasError() {
 		return proto6Stream, &ListResourceSchemaNotFoundError{TypeName: proto6Req.TypeName}