Tidy

Author: bbasata

internal/fwserver/server_listresource.go

@@ -140,5 +140,5 @@ func processListResult(req list.ListRequest, result list.ListResult) ListResult
 		}
 	}
 
-	return ListResult(result) // TODO: do we want to .Copy() the raw Identity and Resource values?
+	return ListResult(result)
 }

internal/proto5server/serve.go

@@ -12,7 +12,6 @@ import (
 )
 
 var _ tfprotov5.ProviderServer = &Server{}
-var _ tfprotov5.ProviderServerWithListResource = &Server{} //nolint:staticcheck
 
 // Provider server implementation.
 type Server struct {

internal/proto6server/serve.go

@@ -12,7 +12,6 @@ import (
 )
 
 var _ tfprotov6.ProviderServer = &Server{}
-var _ tfprotov6.ProviderServerWithListResource = &Server{} //nolint:staticcheck
 
 // Provider server implementation.
 type Server struct {

list/list_resource.go

@@ -117,9 +117,6 @@ type ListResultsStream struct {
 	// To indicate a fatal processing error, push a [ListResult] that contains
 	// a [diag.ErrorDiagnostic].
 	Results iter.Seq[ListResult]
-
-	// Diagnostics report errors or warnings related to the list operation.
-	Diagnostics diag.Diagnostics
 }
 
 // NoListResults is an iterator that pushes zero results.

tfsdk/resource.go

@@ -44,7 +44,7 @@ func (r Resource) PathMatches(ctx context.Context, pathExpr path.Expression) (pa
 	return r.data().PathMatches(ctx, pathExpr)
 }
 
-// Set populates the entire identity using the supplied Go value. The value `val`
+// Set populates the entire resource using the supplied Go value. The value `val`
 // should be a struct whose values have one of the attr.Value types. Each field
 // must be tagged with the corresponding schema field.
 func (r *Resource) Set(ctx context.Context, val interface{}) diag.Diagnostics {