Skip to content

Commit d2157d1

Browse files
committed
update doc comments
1 parent b0a34a9 commit d2157d1

24 files changed

+30
-58
lines changed

ephemeral/close.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type CloseRequest struct {
2323
// to the ephemeral resource's Close function, in which the provider
2424
// should set values on the CloseResponse as appropriate.
2525
type CloseResponse struct {
26-
// Diagnostics report errors or warnings related to creating the
26+
// Diagnostics report errors or warnings related to closing the
2727
// resource. An empty slice indicates a successful operation with no
2828
// warnings or errors generated.
2929
Diagnostics diag.Diagnostics

ephemeral/configure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type ConfigureRequest struct {
2727
// EphemeralResource type Configure method.
2828
type ConfigureResponse struct {
2929
// Diagnostics report errors or warnings related to configuring of the
30-
// Datasource. An empty slice indicates a successful operation with no
30+
// EphemeralResource. An empty slice indicates a successful operation with no
3131
// warnings or errors generated.
3232
Diagnostics diag.Diagnostics
3333
}

ephemeral/deferred.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const (
88
// Provider developers should not use it.
99
DeferredReasonUnknown DeferredReason = 0
1010

11-
// DeferredReasonEphemeralResourceConfigUnknown is used to indicate that the ephemeral resource configuration
11+
// DeferredReasonEphemeralResourceConfigUnknown is used to indicate that the resource configuration
1212
// is partially unknown and the real values need to be known before the change can be planned.
1313
DeferredReasonEphemeralResourceConfigUnknown DeferredReason = 1
1414

ephemeral/ephemeral_resource.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ type EphemeralResourceWithRenew interface {
5353

5454
// EphemeralResourceWithClose is an interface type that extends
5555
// EphemeralResource to include a method which the framework will call when
56-
// Terraform determines that the ephemeral values can be safely cleaned up.
56+
// Terraform determines that the ephemeral resource can be safely cleaned up.
5757
type EphemeralResourceWithClose interface {
5858
EphemeralResource
5959

@@ -76,7 +76,7 @@ type EphemeralResourceWithConfigure interface {
7676

7777
// EphemeralResourceWithConfigValidators is an interface type that extends EphemeralResource to include declarative validations.
7878
//
79-
// Declaring validation using this methodology simplifies implmentation of
79+
// Declaring validation using this methodology simplifies implementation of
8080
// reusable functionality. These also include descriptions, which can be used
8181
// for automating documentation.
8282
//

ephemeral/open.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ type OpenResponse struct {
5050
// Open operation. This field is not pre-populated as there is no
5151
// pre-existing private state data during the ephemeral resource's
5252
// Open operation.
53+
//
54+
// This private data will be passed to any Renew or Close operations.
5355
Private *privatestate.ProviderData
5456

5557
// RenewAt is an optional date/time field that indicates to Terraform
@@ -62,7 +64,7 @@ type OpenResponse struct {
6264
// skew.
6365
RenewAt time.Time
6466

65-
// Diagnostics report errors or warnings related to creating the
67+
// Diagnostics report errors or warnings related to opening the ephemeral
6668
// resource. An empty slice indicates a successful operation with no
6769
// warnings or errors generated.
6870
Diagnostics diag.Diagnostics

ephemeral/renew.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@ type RenewResponse struct {
4141
// Private is the private state ephemeral resource data following the
4242
// Renew operation. This field is pre-populated from RenewRequest.Private
4343
// and can be modified during the ephemeral resource's Renew operation.
44+
//
45+
// This private data will be passed to any Renew or Close operations.
4446
Private *privatestate.ProviderData
4547

46-
// Diagnostics report errors or warnings related to creating the
48+
// Diagnostics report errors or warnings related to renewing the ephemeral
4749
// resource. An empty slice indicates a successful operation with no
4850
// warnings or errors generated.
4951
Diagnostics diag.Diagnostics

ephemeral/schema.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ type SchemaResponse struct {
1919
// Schema is the schema of the ephemeral resource.
2020
Schema schema.Schema
2121

22-
// Diagnostics report errors or warnings related to validating the data
23-
// source configuration. An empty slice indicates success, with no warnings
22+
// Diagnostics report errors or warnings related to retrieving the ephemeral
23+
// resource schema. An empty slice indicates success, with no warnings
2424
// or errors generated.
2525
Diagnostics diag.Diagnostics
2626
}

ephemeral/schema/bool_attribute.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ type BoolAttribute struct {
5555

5656
// Sensitive indicates whether the value of this attribute should be
5757
// considered sensitive data. Setting it to true will obscure the value
58-
// in CLI output. Sensitive does not impact how values are stored, and
59-
// practitioners are encouraged to store their state as if the entire
60-
// file is sensitive.
58+
// in CLI output.
6159
Sensitive bool
6260

6361
// Description is used in various tooling, like the language server, to

ephemeral/schema/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33

44
// Package schema contains all available schema functionality for ephemeral resources.
55
// Ephemeral resource schemas define the structure and value types for configuration
6-
// and state data. Schemas are implemented via the ephemeral.EphemeralResource type
6+
// and result data. Schemas are implemented via the ephemeral.EphemeralResource type
77
// Schema method.
88
package schema

ephemeral/schema/dynamic_attribute.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ type DynamicAttribute struct {
5656

5757
// Sensitive indicates whether the value of this attribute should be
5858
// considered sensitive data. Setting it to true will obscure the value
59-
// in CLI output. Sensitive does not impact how values are stored, and
60-
// practitioners are encouraged to store their state as if the entire
61-
// file is sensitive.
59+
// in CLI output.
6260
Sensitive bool
6361

6462
// Description is used in various tooling, like the language server, to

0 commit comments

Comments
 (0)