Skip to content

Commit f6b4307

Browse files
committed
Tidy comments
1 parent 7f3191d commit f6b4307

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

internal/fwserver/server_listresource.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ func (s *Server) ListResource(ctx context.Context, fwReq *ListRequest, fwStream
8888
req := list.ListRequest{
8989
Config: *fwReq.Config,
9090
IncludeResource: fwReq.IncludeResource,
91-
ResourceSchema: fwReq.ResourceSchema, // TODO: revisit
92-
ResourceIdentitySchema: fwReq.ResourceIdentitySchema, // TODO: revisit
91+
ResourceSchema: fwReq.ResourceSchema,
92+
ResourceIdentitySchema: fwReq.ResourceIdentitySchema,
9393
}
9494

9595
stream := &list.ListResultsStream{}
@@ -140,5 +140,5 @@ func processListResult(req list.ListRequest, result list.ListResult) ListResult
140140
}
141141
}
142142

143-
return ListResult(result) // TODO: do we need to .Copy() the raw Identity and Resource values?
143+
return ListResult(result) // TODO: do we want to .Copy() the raw Identity and Resource values?
144144
}

internal/fwserver/server_listresource_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func TestServerListResource(t *testing.T) {
109109
request: &fwserver.ListRequest{
110110
Config: &tfsdk.Config{},
111111
ListResource: &testprovider.ListResource{
112-
ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) { // TODO
112+
ListMethod: func(ctx context.Context, req list.ListRequest, resp *list.ListResultsStream) {
113113
resp.Results = slices.Values([]list.ListResult{
114114
{
115115
Identity: &tfsdk.ResourceIdentity{

0 commit comments

Comments
 (0)