Skip to content

Conversation

@stephybun
Copy link
Member

@stephybun stephybun commented Jun 26, 2025

Description

Populates and return ListResourceSchemas in the GetProviderSchemaResponse method for the GetProviderSchema RPC for both protov5 and protov6.

Performed some alphabetical reorderings in the expected objects as well..

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

None

@stephybun stephybun requested a review from a team as a code owner June 26, 2025 13:15
@stephybun stephybun marked this pull request as draft June 26, 2025 13:21
@stephybun stephybun marked this pull request as draft June 26, 2025 13:21
@stephybun stephybun marked this pull request as ready for review June 30, 2025 09:17
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch! Not sure how we got so far without actually returning the schemas in the protocol 😅

On this same note, the GetMetadata RPC implementations have the same problem (fwserver is implemented, but toproto isn't actually sending anything back)

for _, datasource := range fw.DataSources {
protov5.DataSources = append(protov5.DataSources, DataSourceMetadata(ctx, datasource))
}
for _, ephemeralResource := range fw.EphemeralResources {
protov5.EphemeralResources = append(protov5.EphemeralResources, EphemeralResourceMetadata(ctx, ephemeralResource))
}
for _, function := range fw.Functions {
protov5.Functions = append(protov5.Functions, FunctionMetadata(ctx, function))
}
for _, resource := range fw.Resources {
protov5.Resources = append(protov5.Resources, ResourceMetadata(ctx, resource))
}

@stephybun
Copy link
Member Author

I suspect they were deliberately left alone as an onboarding task for me 🙂

I'll get on the GetMetadata ones too!

@stephybun stephybun enabled auto-merge (squash) July 1, 2025 06:44
@stephybun stephybun merged commit ca23057 into main Jul 1, 2025
35 checks passed
@stephybun stephybun deleted the f/list-in-get-provider-schema branch July 1, 2025 06:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2025
@austinvalle austinvalle added this to the v1.16.0 milestone Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants