Improve dynamic attribute internal validation handling #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBGoods
commented
Feb 11, 2025
austinvalle
reviewed
Feb 11, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Left some thoughts on the dynamic attribute validation, everything else looks good!
Also thank you for leaving a bread crumb in the comments, that was very helpful 🙏🏻
SBGoods
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #1044
Mainly adds logic to handle underlying null values for dynamic attributes in the internal attribute validation. It also addresses minor comments in the write-only attribute PR.