Implement validation logic for "identityschema.ListAttribute" #1125
+247
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainkwan
force-pushed
the
rk/resource-identity-validation
branch
from
4463c26 to
d92419d
Compare
austinvalle
reviewed
Apr 14, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Looking good 👍🏻 , I have some suggestions for the case switch + diagnostic messaging, but all the functionality looks correct!
rainkwan
force-pushed
the
rk/resource-identity-validation
branch
from
7062e88 to
66ae7b6
Compare
…ure it is an allowed primitive
Co-authored-by: Austin Valle <[email protected]>
Co-authored-by: Austin Valle <[email protected]>
rainkwan
force-pushed
the
rk/resource-identity-validation
branch
from
66ae7b6 to
49ed817
Compare
rainkwan
commented
Apr 16, 2025
austinvalle
previously approved these changes
Apr 17, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Just had one small adjustment to the error message, great work on this! 🙌🏻
Co-authored-by: Austin Valle <[email protected]>
Co-authored-by: Austin Valle <[email protected]>
Co-authored-by: Austin Valle <[email protected]>
Co-authored-by: Austin Valle <[email protected]>
austinvalle
approved these changes
Apr 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the “invalid” identity attribute types are simply not possible to create with Framework (without abusing custom types, which we can safely ignore imo) because we have a dedicated “identityschema” package: https://github.com/hashicorp/terraform-plugin-framework/tree/main/resource/identityschema
The lone validation we need to apply at runtime is checking the element type of the “identityschema.ListAttribute” since there is no restriction on what kind of “attr.Type” is provided. The only allowed element types are:
types.Bool
types.Int64, types.Int32, types.Float64, types.Float32, types.Number
types.String
The validation was done in the ValidateImplementation function which runs during GetResourceIdentitySchemas.
Added AttributeInvalidElementTypeDiag to give the error message and IsAllowedPrimitiveType to check to see if the element is an allowed type.