list: add map, list and single nested blocks and attributes #1201
Conversation
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
I left a thread comment continuing some of our slack thread, but the code itself all looks good 👍🏻
| // Additionally, the NestedAttribute interface extends Attribute with nested | ||
| // attributes. Only supported in protocol version 6. Implementations in this | ||
| // package include: | ||
| // - ListNestedAttribute |
There was a problem hiding this comment.
Responding to the description in a thread, not blocking for this PR imo
As a team, we should probably align the attribute/type/block support we want for actions and list, since my understanding is both schemas are identical in what they are used for (configuration). As you noted in the description, the final difference between the two after this PR is all of the set types (SetAttribute, SetNestedBlock, SetNestedAttribute).
If the schemas are being used differently and the usage of the set type isn't possible or would cause issues, then we can at least document it ahead of time for developers / future maintainers that the decision was intentional and not a miss.
If we want to take a general stance that we don't want to support set for new schemas in framework, then we should consider removing the set related attributes/blocks from the action schemas as well.
| ) | ||
|
|
||
| // Ensure the implementation satisifies the desired interfaces. | ||
| // Ensure the implementation satisfies the desired interfaces. |
There was a problem hiding this comment.
Oh no, this spelling error is everywhere 🤣
2 participants
Description
Adds map, list and single nested blocks and attributes. Deliberately left out support for sets but we could look into adding these if/when there is a specific request for them.
Rollback Plan
Changes to Security Controls
None