Merge pull request #11 from hashicorp/paddy_legacy_type_system

Support the legacy type system.

Author: kmoe

tfprotov5/internal/fromproto/resource.go

@@ -99,7 +99,8 @@ func PlanResourceChangeRequest(in *tfplugin5.PlanResourceChange_Request) (*tfpro
 
 func PlanResourceChangeResponse(in *tfplugin5.PlanResourceChange_Response) (*tfprotov5.PlanResourceChangeResponse, error) {
 	resp := &tfprotov5.PlanResourceChangeResponse{
-		PlannedPrivate: in.PlannedPrivate,
+		PlannedPrivate:              in.PlannedPrivate,
+		UnsafeToUseLegacyTypeSystem: in.LegacyTypeSystem,
 	}
 	attributePaths, err := AttributePaths(in.RequiresReplace)
 	if err != nil {
@@ -139,7 +140,8 @@ func ApplyResourceChangeRequest(in *tfplugin5.ApplyResourceChange_Request) (*tfp
 
 func ApplyResourceChangeResponse(in *tfplugin5.ApplyResourceChange_Response) (*tfprotov5.ApplyResourceChangeResponse, error) {
 	resp := &tfprotov5.ApplyResourceChangeResponse{
-		Private: in.Private,
+		Private:                     in.Private,
+		UnsafeToUseLegacyTypeSystem: in.LegacyTypeSystem,
 	}
 	diags, err := Diagnostics(in.Diagnostics)
 	if err != nil {

tfprotov5/internal/toproto/resource.go

@@ -97,7 +97,8 @@ func PlanResourceChange_Request(in *tfprotov5.PlanResourceChangeRequest) (*tfplu
 
 func PlanResourceChange_Response(in *tfprotov5.PlanResourceChangeResponse) (*tfplugin5.PlanResourceChange_Response, error) {
 	resp := &tfplugin5.PlanResourceChange_Response{
-		PlannedPrivate: in.PlannedPrivate,
+		PlannedPrivate:   in.PlannedPrivate,
+		LegacyTypeSystem: in.UnsafeToUseLegacyTypeSystem, //nolint:staticcheck
 	}
 	requiresReplace, err := AttributePaths(in.RequiresReplace)
 	if err != nil {
@@ -137,7 +138,8 @@ func ApplyResourceChange_Request(in *tfprotov5.ApplyResourceChangeRequest) (*tfp
 
 func ApplyResourceChange_Response(in *tfprotov5.ApplyResourceChangeResponse) (*tfplugin5.ApplyResourceChange_Response, error) {
 	resp := &tfplugin5.ApplyResourceChange_Response{
-		Private: in.Private,
+		Private:          in.Private,
+		LegacyTypeSystem: in.UnsafeToUseLegacyTypeSystem, //nolint:staticcheck
 	}
 	diags, err := Diagnostics(in.Diagnostics)
 	if err != nil {

tfprotov5/resource.go

@@ -62,6 +62,20 @@ type PlanResourceChangeResponse struct {
 	RequiresReplace []*tftypes.AttributePath
 	PlannedPrivate  []byte
 	Diagnostics     []*Diagnostic
+
+	// This field should only be set by hashicorp/terraform-plugin-sdk.
+	// It modifies Terraform's behavior to work with the legacy
+	// expectations of that SDK.
+	//
+	// Nobody else should use this. Ever. For any reason. Just don't do it.
+	//
+	// We have to expose it here for terraform-plugin-sdk to be muxable, or
+	// we wouldn't even be including it in this type. Don't use it. It may
+	// go away or change behavior on you with no warning. It is
+	// explicitly unsupported and not part of our SemVer guarantees.
+	//
+	// Deprecated: Really, just don't use this, you don't need it.
+	UnsafeToUseLegacyTypeSystem bool
 }
 
 type ApplyResourceChangeRequest struct {
@@ -77,6 +91,20 @@ type ApplyResourceChangeResponse struct {
 	NewState    *DynamicValue
 	Private     []byte
 	Diagnostics []*Diagnostic
+
+	// This field should only be set by hashicorp/terraform-plugin-sdk.
+	// It modifies Terraform's behavior to work with the legacy
+	// expectations of that SDK.
+	//
+	// Nobody else should use this. Ever. For any reason. Just don't do it.
+	//
+	// We have to expose it here for terraform-plugin-sdk to be muxable, or
+	// we wouldn't even be including it in this type. Don't use it. It may
+	// go away or change behavior on you with no warning. It is
+	// explicitly unsupported and not part of our SemVer guarantees.
+	//
+	// Deprecated: Really, just don't use this, you don't need it.
+	UnsafeToUseLegacyTypeSystem bool
 }
 
 type ImportResourceStateRequest struct {